1669014 - Use different keys for OpenPGP tests (keys from https://gitlab.com/openpgp-wg/openpgp-samples)

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement, P1)

Description

[Kai Engert (:KaiE:)]

Thank you for creating the initial OpenPGP tests in bug 1651492, that is an important starting point.

I notice that all keys are of type RSA. It would be good to use keys for both RSA and ECC, to ensure we test that both work.

For additional tests, I'd prefer to use the test keys that have been published at https://gitlab.com/openpgp-wg/openpgp-samples

Reasons:

As part of earlier bug reports, I have already been given real world test messages that used the above keys, so if we want to include them in automated testing, we'll have to include the above keys in our test suite, too.

Because those keys also use the Alice/Bob names, it might be a little confusing to have different keys in those names.

So one detail we'll have to decide is: Should we change the existing tests to use the keys from gitlab? Or should we have a separate area for test messages and keys that use the gitlab keys?

Another minor detail: Some filenames use "autocrypt". I think the focus of those message is to test an attached key, which we currently send as both attachment and as an autocrypt header. Maybe it would make sense to rename -autocrypt.eml to -with-key.eml

Comment 1

[Magnus Melin [:mkmelin]]

I think we might as well change the existing tests to use keys from gitlab.

Comment 2

[Lasana Murray]

Attachment: 1669014.patch

Changed keys, regenerated emails.

Comment 3

[Lasana Murray]

Try run in progress:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7676d64cca083f73036b9f8c10dbd877d3f365f6

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8d0cbdd474a3
Use openpgp.example keys for openpgp browser tests. r=mkmelin

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/8de0d8b7b512

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9181660 [details] [diff] [review]
1669014.patch

[Triage Comment]
Required for OpenPGP mochitests to run properly on c-esr78.