1669044 - Menus API OnClickData's selectedFolder not showing full MailFolder

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Joaquín Serna]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Install a local extension with the following permissions: ["messagesRead", "accountsFolders", "accountsRead", "downloads", "menus"]

Create a menu with the following contexts: ["message_list", "folder_pane"]

Create a folder and create a couple of subfolders

Right-click on the folder in the folder pane and click the menu created

Actual results:

Viewing the menu's API OnClickData "selectedFolder" property generated by that interaction it only shows accountId, name and path but not subFolders.

Viewing the same folder but by filtering through the account's API MailAccount "folders" property shows the full MailFolder properties.

Expected results:

Both API's to behave the same way.

Comment 1

[Joaquín Serna]

I belive this can be fixed by changing this line by traversing the folder like in the account's internal function convertAccount but I'm not sure if thats even possible.

Comment 2

[Joaquín Serna]

Attachment: menu_subfolder.patch

I've just modified the code to make it work as I expected and tested it with the same extension without any problems.
Let's hope this patch is useful and can be applied upstream soon!

Comment 3

[Magnus Melin [:mkmelin]]

Thanks for the patch Joaquín. To get it reviewed, to into the spilter review and select the review box, choose :darktrojan as reviewer

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9179789 [details] [diff] [review]
menu_subfolder.patch

Perfect. Thank you.

Comment 5

[Geoff Lankow (:darktrojan)]

I've made a few tweaks and landed this. It seems there's some infrastructure issues, but a bot should appear shortly and close this bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ed29df27b2a
Add MailFolder's subfolders to displayedFolder and selectedFolder. r=darktrojan

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9179789 [details] [diff] [review]
menu_subfolder.patch

[Approval Request Comment]
WX API correctness fix.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9179789 [details] [diff] [review]
menu_subfolder.patch

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/53db3388ea24

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9179789 [details] [diff] [review]
menu_subfolder.patch

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/ebf0df8a6c78