1669050 - Cannot paste SVG images inside contenteditable

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

Attachment: svg-image-paste.html

1. Open the attachment
2. Select and copy the whole line
3. Paste it

Expected: A new copy of the line including the images (and selecting SVG ideally should show selection indicator background)
Actual: SVG image becomes blank while <img> manages to be alive

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that we should take a look this when we have much time since user may lost important SVG data on some web apps.

Comment 2

[denis.rosas]

I'm having a similar issue. I can't paste any image to Whatsapp Web and to OneDrive document editor.
Usually I use snipping tool to capture a part of the screen and then I paste it in a OneDrive document or in a Whastapp Web conversation.
The image won't show up.

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

What's copied to the clipboard, is correct:

"text/html" flavor:

<meta http-equiv="content-type" content="text/html; charset=utf-8">foo
  <svg width="200" height="200" xmlns="http://www.w3.org/2000/svg">
    <image href="https://mdn.mozillademos.org/files/6457/mdn_logo_only_color.png" height="200" width="200"></image>
  </svg>
  <img src="https://mdn.mozillademos.org/files/6457/mdn_logo_only_color.png" width="200" height="200">
  bar

The error happens on pasting:

  foo
  <svg width="200" height="200" xmlns="http://www.w3.org/2000/svg">
    <image height="200" width="200"></image>
  </svg>
  <img src="https://mdn.mozillademos.org/files/6457/mdn_logo_only_color.png" width="200" height="200">
  bar

the href is dropped.

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia)]

Can you please provide a concrete example? Which Operating System and which Firefox build are you using?
I'm wondering if the issue you've described is about HTML <img>s or SVG <image>s.

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

The href attribute is removed during tree-sanitization. This is part of the call-stack.

Adding the attribute to kAttributesSVG fixes the bug.
However, I need to think whether this is the proper fix and if this doesn't break anything else.

Comment 6

[Robert Longson [:longsonr]]

Given that we allow it for mathml and we allow the equivalent src for HTML, we should allow href for SVG.

Comment 7

[Mirko Brodesser (:mbrodesser-Igalia)]

:longsonr: agree. Fix is ready, will create a review once the test is ready.

Comment 8

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1669050: add `href` to the allowed SVG attributes in `nsTreeSanitizer`. r=hsivonen

This follows the pattern of kAttributesHTML and kURLAttributesHTML,
which both contain href. Now, kAttributesSVG and kURLAttributesSVG
contain href too.

Unfortunately, the WPT-support for filling and reading the clipboard is
scanty (see bug 1676643), hence adding a Mochitest.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15090a85909d
add `href` to the allowed SVG attributes in `nsTreeSanitizer`. r=hsivonen

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/15090a85909d