1677092 - Add `constexpr` `AnyOf`

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Mirko Brodesser (:mbrodesser-Igalia)]

The constexpr version is only supported by C++20.

Comment 1

[Simon Giesecke [:sg] [he/him]]

(In reply to Mirko Brodesser (:mbrodesser) from comment #0)

The constexpr version is only supported by C++20.

You mean std::any_of is only constexpr in C++20, and so we should add a constexpr mozilla::AnyOf until we upgrade to C++20?

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

(In reply to Simon Giesecke [:sg] [he/him] from comment #1)

(In reply to Mirko Brodesser (:mbrodesser) from comment #0)

The constexpr version is only supported by C++20.

You mean std::any_of is only constexpr in C++20, and so we should add a constexpr mozilla::AnyOf until we upgrade to C++20?

Exactly. Will create a review soon.

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1677092: add `constexpr` `AnyOf`. r=sg

The STL supports it only with C++20.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8531203d7207
add `constexpr` `AnyOf`. r=sg

Comment 5

[Razvan Maries]

Backed out for build bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8531203d720778399e4317445b2d5d42b929f430&selectedTaskRun=QrhpAQZ2S_mQqzswlqHsHQ.0

Log: https://treeherder.mozilla.org/logviewer?job_id=321879502&repo=autoland&lineNumber=36211

Backout: https://hg.mozilla.org/integration/autoland/rev/c1478fe4a2a75467bfdf73d80060d8ccf2eecffa

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/661a809df660
add `constexpr` `AnyOf`. r=sg

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/661a809df660