1669225 - The printer select dropdown shouldn't be disabled when we have invalid values

Status: VERIFIED FIXED

(Toolkit :: Printing, enhancement, P1)

Description

[Julien Wajsberg [:julienw]]

Attachment: Capture d’écran de 2020-10-05 11-20-11.png

STR:

1. Set some margin values to a negative value (eg: set to -1)
2. Try to print preview.

To be clear, for me this happens when a non-existing printer is selected (not sure how to describe it better). So that wouldn't be a big problem... except that once it's selected, the printer select dropdown is disabled too so we can't select another printer. That's the specific issue we'd like to address in this bug.

See bug 1669207 and bug 1663503 for more background about this.

Comment 1

[Jonathan Watt [:jwatt]]

This seems really important. If we end up locking the UI due to an error with the (possibly default) selected printer, the user can't even switch to a valid printer and so they're basically locked out of being able to print.

Comment 2

[Emma Malysz]

Attachment: Bug 1669225, enable destination dropdown when invalid values exist in the form

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86062362df9a
enable destination dropdown when invalid values exist in the form r=sfoster

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/86062362df9a

Comment 5

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2020-10-05) on Windows 10 x64.
I retested everything using latest Nightly 85.0a1 and Firefox 84.0b3 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 11.0.1. The issue is not reproducing anymore.