Closed Bug 1669333 Opened 8 months ago Closed 7 months ago

Broaden "slicing" fragmentation fallback to use logical coordinates (track overflow in block axis, not necessarily vertical axis) so that it works with vertical-writing-mode documents

Categories

(Core :: Printing: Output, defect, P3)

defect
Points:
3

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: dholbert, Assigned: mats)

References

Details

Attachments

(1 file, 1 obsolete file)

I'm spinning off this bug to cover the issues brought up in bug 1640197 comment 26.

(That bug's implementation only works for documents with the default horizontal writing mode. If you specify a vertical writing-mode on the html element, then the overflow in the block axis gets lost when it should be preserved; and the overflow in the inline axis gets preserved when it should be cropped.)

Testcases:
"testcase 3" from bug 1640197: horizontal writing-mode, everything is mostly fine.
https://bugzilla.mozilla.org/attachment.cgi?id=9179658

testcase 4 from bug 1640197: Same as testcase 3 but with vertical writing-mode. It should fragment just as well as testcase 3, but it does not; the numbered content is lost after page 1 (due to this bug)
https://bugzilla.mozilla.org/attachment.cgi?id=9179659

testcase 5 from bug 1640197: same as testcase 4, but with a wide "aaaaaaaa..." added. The "aaa..." overflow should be clipped since it's overflowing in the inline axis, but in fact we end up painting it on subsequent pages (superimposed with our correctly-fragmented-in-the-Block-Axis content)
https://bugzilla.mozilla.org/attachment.cgi?id=9179665

Screenshot of testcase 5, showing that part of the issue:
https://bugzilla.mozilla.org/attachment.cgi?id=9179677

Summary: Broaden "slicing" fragmentation fallback to use logical coordinates (track overflow in block axis, not necessarily vertical axis) → Broaden "slicing" fragmentation fallback to use logical coordinates (track overflow in block axis, not necessarily vertical axis) so that it works with vertical-writing-mode documents
Attached patch 1669333-wip.patch (obsolete) — Splinter Review

I took a go at this and got the two vertical writing-mode testcases working with this patch. Changing the testcase from vertical-lr to vertical-rl produces output that does not look fully correct, so maybe this patch is not complete.

Assignee: nobody → mats
Type: task → defect
Points: --- → 3
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Attachment #9181802 - Attachment is obsolete: true
Severity: -- → S3
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef0dabb6cb66
Make the fragmentation fallback code use logical coordinates.  r=jfkthame
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26672 for changes under testing/web-platform/tests
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Upstream PR merged by moz-wptsync-bot
Blocks: 1681052
You need to log in before you can comment on or make changes to this bug.