1669333 - Broaden "slicing" fragmentation fallback to use logical coordinates (track overflow in block axis, not necessarily vertical axis) so that it works with vertical-writing-mode documents

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P3)

Description

[Daniel Holbert [:dholbert]]

I'm spinning off this bug to cover the issues brought up in bug 1640197 comment 26.

(That bug's implementation only works for documents with the default horizontal writing mode. If you specify a vertical writing-mode on the html element, then the overflow in the block axis gets lost when it should be preserved; and the overflow in the inline axis gets preserved when it should be cropped.)

Testcases:
"testcase 3" from bug 1640197: horizontal writing-mode, everything is mostly fine.
https://bugzilla.mozilla.org/attachment.cgi?id=9179658

testcase 4 from bug 1640197: Same as testcase 3 but with vertical writing-mode. It should fragment just as well as testcase 3, but it does not; the numbered content is lost after page 1 (due to this bug)
https://bugzilla.mozilla.org/attachment.cgi?id=9179659

testcase 5 from bug 1640197: same as testcase 4, but with a wide "aaaaaaaa..." added. The "aaa..." overflow should be clipped since it's overflowing in the inline axis, but in fact we end up painting it on subsequent pages (superimposed with our correctly-fragmented-in-the-Block-Axis content)
https://bugzilla.mozilla.org/attachment.cgi?id=9179665

Comment 1

[Daniel Holbert [:dholbert]]

Screenshot of testcase 5, showing that part of the issue:
https://bugzilla.mozilla.org/attachment.cgi?id=9179677

Comment 2

[Miko Mynttinen]

Attachment: 1669333-wip.patch

I took a go at this and got the two vertical writing-mode testcases working with this patch. Changing the testcase from vertical-lr to vertical-rl produces output that does not look fully correct, so maybe this patch is not complete.

Comment 3

[Mats Palmgren (inactive)]

Attachment: Bug 1669333 - Make the fragmentation fallback code use logical coordinates. r=jfkthame

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef0dabb6cb66
Make the fragmentation fallback code use logical coordinates.  r=jfkthame

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26672 for changes under testing/web-platform/tests

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ef0dabb6cb66

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot