1669390 - We're failing to track telemetry for silent printing when print.tab_modal.enabled is true

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P2)

Description

[Jonathan Watt [:jwatt]]

Bug 1662222 changed the settingsAreComplete variable so that we include invocations by extensions which tend to be where our silent prints come from. That means we don't enter the block of code that tracks silent prints in early-beta-and-earlier where the pref is on by default..

https://searchfox.org/mozilla-central/rev/35245411b9e8a911fe3f5adb0632c3394f8b4ccb/layout/printing/nsPrintJob.cpp#642-648,653,663-665

FWIW, the telemetry code was originally written that way to avoid counting silent prints in the two "dialog opened" probes.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1669390. Fix silent printing telemetry when print.tab_modal.enabled is true. r=bobowen

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1adba2961bf0
Fix silent printing telemetry when print.tab_modal.enabled is true. r=bobowen

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 9179774 [details]
Bug 1669390. Fix silent printing telemetry when print.tab_modal.enabled is true. r=bobowen

Beta/Release Uplift Approval Request

• User impact if declined: We can't filter out print paper sizes from add-on initiated prints, which limits the usefulness of the paper size telemetry we're gathering.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple patch with affect limited to telemetry gathering only. In the event that something was wrong with the patch, we'd break the already broken telemetry in a different way.
• String changes made/needed:

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9179774 [details]
Bug 1669390. Fix silent printing telemetry when print.tab_modal.enabled is true. r=bobowen

approved for 82.0b8

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/03b4618596a8

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1adba2961bf0