1669509 - Chrome indexeddb databases show up in the devtools' storage panel for a webpage

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P1)

Description

[Julien Wajsberg [:julienw]]

Attachment: Capture d’écran de 2020-10-06 16-15-23.png

STR:

1. go on any webpage, for example this page.
2. open the devtools' storage panel
3. open the Indexed DB item

=> we see entries that are related to Firefox in addition to the entry for the current website.

Julian said this is happening when Remote Debugging + Chrome debugging is enabled.

This seems quite new.

Comment 1

[Julien Wajsberg [:julienw]]

I ran mozregression and found:
pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=37cd0824dd4b3d84fc5a68cfd91150c1af77146a&tochange=3e4fdf53c557132a0cb11b7dc3964e61844e7b31
bug 1625935

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks Julien for the report and regression bug!
I can reproduce on my machine easily (Win10, Nightly)

Alex, do you know what caused the issue in David's patch?

Honza

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1625935

Comment 4

[Belén [:ladybenko]]

Attachment: Bug 1669509 - [devtools] Hide internal indexedDB's when we are not in the browser toolbox

In https://phabricator.services.mozilla.com/D91122#C3084925OL296 we transferred the filtering of indexedDB dbs to a transformer, but it was not being applied since the hosts getter was still used by the client. Since we discussed this filtering should be done in the server, this patch moves the filtering to the storage actor instead.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a4c2dc63d04
[devtools] Hide internal indexedDB's when we are not in the browser toolbox r=ochameau

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for causing leaks

backout: https://treeherder.mozilla.org/logviewer?job_id=320268239&repo=autoland&lineNumber=2819

push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=WTDJ1pe2TCqh1EBCtwTZBA.0&revision=5a4c2dc63d045e41648971c4c2803efb970885f8&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=320270436&repo=autoland&lineNumber=4399

[task 2020-10-30T16:39:39.580Z] 16:39:39 INFO - TEST-INFO | Main app process: exit 0
[task 2020-10-30T16:39:39.580Z] 16:39:39 INFO - TEST-INFO | LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2020-10-30T16:39:39.580Z] 16:39:39 INFO - TEST-INFO | LeakSanitizer | This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2020-10-30T16:39:39.580Z] 16:39:39 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at nsDNSAsyncRequest::OnResolveHostComplete, nsHostResolver::ResolveHost, nsDNSService::AsyncResolveInternal, mozilla::net::nsSocketTransport::ResolveHost
[task 2020-10-30T16:39:39.580Z] 16:39:39 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at Malloc, nsTArray_base, nsTArray_Impl, AppendElement
[task 2020-10-30T16:39:39.581Z] 16:39:39 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at nsHostResolver::InitLoopbackRecord, nsHostResolver::ResolveHost, nsDNSService::AsyncResolveInternal, mozilla::net::nsSocketTransport::ResolveHost
[task 2020-10-30T16:39:39.581Z] 16:39:39 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at nsHostResolver::InitRecord, nsHostResolver::InitLoopbackRecord, nsHostResolver::ResolveHost, nsDNSService::AsyncResolveInternal
[task 2020-10-30T16:39:39.581Z] 16:39:39 INFO - runtests.py | Application ran for: 0:03:12.032371
[task 2020-10-30T16:39:39.581Z] 16:39:39 INFO - zombiecheck | Reading PID log: /tmp/tmpG8b_1Vpidlog

*Other failure log: https://treeherder.mozilla.org/logviewer?job_id=320268239&repo=autoland&lineNumber=2819

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f84dc1d5bf7d
Backed out changeset 5a4c2dc63d04 for causing leaks. CLOSED TREE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba47f1f0ecc9
[devtools] Hide internal indexedDB's when we are not in the browser toolbox r=ochameau

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ba47f1f0ecc9

Comment 10

[Pascal Chevrel:pascalc]

Belén, you marked this bug as P1, do you intend to request an uplift in 83 beta or can it ride the 84 train? Thanks

Comment 11

[Belén [:ladybenko]]

Hi, no uplifting is needed, thanks!