1625935 - Use the ResourceWatcher API to fetch Storage data

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, task, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 1576624 introduced the ResourceWatcher API, accessible via toolbox.resourceWatcher. This API will help listen to data that is being created early, when the document just started loading.

We should migrate the whole DevTools codebase to this API for any data that:

• DevTools frontend listen to, or care about,
  and,
• may be created or be notified early, when the document just starts being loaded.
  This data will typically be: console messages, errors, warnings, sources, Root element NodeFront, storage values, network events, stylesheets, ...

We are typically not going to use this API for:

• data being fetched on-demand, from user's input. For ex: webconsole evaluation input, or, DOM element expands from the Markup view.
• events which we only want to record when the user cares about them. For ex: animation events.

For some more high level context, please have a look at Migration to Fission-compatible APIs, which describes all Fission-related refactorings.

The typical task for this bug will be about migrating code that:

• start listening and register a RDP event listener,
• retrieve already existings data,
  from panel's codebase, to the ResourceWatcher module, in the LegacyListener object.
  And then, the panel should use the ResourceWatcher instead.

Bug 1620234 is a good example of such migration, applied to Console Messages.
Bug 1623699 is also useful example as it demonstrates how to write tests for such migration.

This bug is about focusing on only one usecase: the storage data.

Existing storage data is being fetched via StorageFront.listStores, from here:
https://searchfox.org/mozilla-central/rev/9c6e7500c0015a2c60be7b1b888261d95095ce27/devtools/client/storage/ui.js#293
And updates are being listened from here:
https://searchfox.org/mozilla-central/rev/9c6e7500c0015a2c60be7b1b888261d95095ce27/devtools/client/storage/ui.js#290-291

We might have to tweak ResourceWatcher here in order to convey the notion of "resource has been updated" and/or "resource has been destroyed".

Comment 1

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 3

[David Walsh :davidwalsh]

Attachment: Bug 1625935 - Implement ResourceWatcher for Storage panel r=ochameau

Comment 4

[David Walsh :davidwalsh]

Attachment: Bug 1625935 - Implement ResourceWatcher for Storage panel r=ochameau

Comment 5

[Belén [:ladybenko]]

Attachment: Add fission storage watchers (wip)

Depends on D86050

Comment 6

[Belén [:ladybenko]]

Attachment: Bug 1625935 - [devtools] Implement ResourceWatcher with legacy listeners for Storage panel r=ochameau

This is D86050, rebased on top of current central. I kept it a separate commit, so the new stuff can be reviewed separately in a different revision.

Comment 7

[Belén [:ladybenko]]

Attachment: Bug 1625935 - Part 2: Add support for receiving an array of resources for update/available/destroy

Depends on D91122. This adds support for receiving an array of resources in the update/available/destroy callbacks

Comment 8

[Neha Kochar [:neha]]

Bulk move of all m2-mvp devtools bugs to Fission M7.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e4fdf53c557
[devtools] Implement ResourceWatcher with legacy listeners for Storage panel r=ochameau

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3e4fdf53c557