Unify the .toolbarbutton-1 styling
Categories
(Thunderbird :: Theme, task)
Tracking
(thunderbird_esr78 wontfix, thunderbird82 wontfix)
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files, 3 obsolete files)
|
9.22 KB,
image/png
|
Details | |
|
60.92 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
Until now we have three different stylings for the toolbarbutton-1. To make it simpler and make it on all platforms the same we should unify the styling and move it to the shared files.
| Assignee | ||
Comment 1•6 years ago
|
||
I used the Linux styling as I think it's the cleanest of the three.
Additionally I tried to make some rules pretty by adding spaces after the commas and make the rules not too long.
Comment 2•6 years ago
|
||
| Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Alessandro Castellani (:aleca) from comment #2)
Comment on attachment 9179965 [details] [diff] [review]
1669542-unify-toolbarbutton-1.patchReview of attachment 9179965 [details] [diff] [review]:
::: mail/themes/osx/mail/messenger.css
@@ +158,5 @@.findbar-button {
background: none;
+}
+
+.toolbarbutton-1 {Is there any reason why this class was named this way? It seems a bit of a
quick and dirty naming.
We should rename it with something more semantically correct, like
button-toolbar.I think it's always better to use a consistent format for classes, always
starting with the element type (eg. button-, input-, row-, etc.) and
separate words with dashes.
For ID selectors instead we should stick with a camelCase, what do you think?
That would mean updating the class above tobutton-findbar.I know that would mean updating pretty much all the files to replace that
class name, so this would most likely be a blocking point for future uplifts.
I'm for doing this in a separate bug. There are almost 300 lines to change and not really the focus of this bug.
::: mail/themes/shared/mail/messenger.css
@@ +223,5 @@+.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker {
- border: 1px solid transparent;
- border-radius: var(--toolbarbutton-border-radius);
- transition-property: background-color, border-color;
- transition-duration: 150ms;
Let's unify these attributes with `transition: background-color .15s,
border-color .15s;
Done.
Comment 4•6 years ago
|
||
I hope this won't lose the native look of buttons on each OS...?
| Assignee | ||
Comment 5•6 years ago
|
||
This is about the toolbarbuttons which have already their own, non-native, styling.
Comment 6•6 years ago
|
||
| Assignee | ||
Comment 7•6 years ago
|
||
I found that .toolbarbutton-1[checked=true]:not(:active):hover didn't worked as the checked rule was stronger. I removed the rule and renamed the --toolbarbutton-checkedhover-backgroundcolor to --toolbarbutton-checked-background and use it on the checked buttons.
Comment 8•6 years ago
|
||
Better, but the checked dark variation still doesn't look great with that 1px spread inset box shadow.
Since the light variation uses the inset box shadow to communicate depths, that approach doesn't translate well in dark variation.
I suggest implementing a linear background color to keep the "depth" feeling, and making it work better with dark themes.
--toolbarbutton-active-boxshadow: none;
--toolbarbutton-checked-background: linear-gradient(rgba(0,0,0,0.1), rgba(255, 255, 255, .1));
| Assignee | ||
Comment 9•6 years ago
|
||
Patch with your checked proposal from Matrix chat.
I also removed unneeded Windows 7 Quick filter bar button styles.
Comment 10•6 years ago
|
||
| Assignee | ||
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/060c1dcc245c
Unify the .toolbarbutton-1 styling. r=aleca
Updated•6 years ago
|
Description
•