1669724 - window_composition_text_querycontent.xhtml is not correctly testing relative insertion points

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Mark Banner (:standard8)]

In bug 1656280 we are looking at enabling more ESLint rules on widget/tests. One of the rules has picked up that widget/tests/window_composition_text_querycontent.xhtml is currently broken:

https://searchfox.org/mozilla-central/rev/1a973762afcbc5066f73f1508b0c846872fe3952/widget/tests/window_composition_text_querycontent.xhtml#5105

  if (!checkContentRelativeToSelection(0, 1, 0, "0", "runQueryContentEventRelativeToInsertionPoint[0-5]", "#1") ||
      !checkContentRelativeToSelection(-1, 1, 0, "0", "runQueryContentEventRelativeToInsertionPoint[0-5]", "#2") ||
      !checkContentRelativeToSelection(1, 1, 1, "1", "runQueryContentEventRelativeToInsertionPoint[0-5]", "#3") ||
      !checkContentRelativeToSelection(5, 10, 5, "56789", "runQueryContentEventRelativeToInsertionPoint[0-5]", "#4") ||
      !checkContentRelativeToSelection(10, 1, 10, "", "runQueryContentEventRelativeToInsertionPoint[0-5]"), "#5") {
    return;
  }

The last part of that statement should have the , "#5" within the checkContentRelativeToSelection arguments.

If we try and change it, then other parts of the tests break. It is unclear what to do to fix those.

This test was added by bug 1275528.

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Inheriting the priority from the meta bug.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Masayuki: can you please set the severity for this ticket (and re-prioritize it, if needed)?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1669724 - Fix the mistake in `runQueryContentEventRelativeToInsertionPoint` in `window_composition_text_querycontent.xhtml` r=m_kato!

This is simple mistake at writing the test.

And also, once fixing the mistake, another bug appears. That is, the second
composition string is not "b", but the following code assumes so. Therefore,
this fixes it too.

Depends on D97269

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a95095384a5
Fix the mistake in `runQueryContentEventRelativeToInsertionPoint` in `window_composition_text_querycontent.xhtml` r=m_kato

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a95095384a5