Closed Bug 1669774 Opened 4 years ago Closed 4 years ago

Rename some implementation-detail APIs and variables to use "sheet" rather than "page", for accuracy

Categories

(Core :: Printing: Setup, task)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Filing this bug to do some cleanup in nsPrintJob.cpp and related calling/caller code, to fix APIs that are now misnamed (e.g. nsPrintJob::PrintPage actually prints a sheet which may contain multiple pages, so it really should be named PrintSheet now).

This feels a bit pedantic, but I think it's worth it for clarity/consistency of language & to reduce areas of ambiguity about places that are dealing with page numbers/counts vs. sheet numbers/counts.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/632236572730 part 1: Rename some nsPageSequenceFrame APIs and vars with s/page/sheet/for accuracy. r=TYLin https://hg.mozilla.org/integration/autoland/rev/f831fe50e3ba part 2: Rename some APIs and variables for accuracy (s/page/sheet/) in nsPrintJob, nsPagePrintTimer, and nsDocumentViewer. r=TYLin
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: