1669774 - Rename some implementation-detail APIs and variables to use "sheet" rather than "page", for accuracy

Status: RESOLVED FIXED

(Core :: Printing: Setup, task)

Description

[Daniel Holbert [:dholbert]]

Filing this bug to do some cleanup in nsPrintJob.cpp and related calling/caller code, to fix APIs that are now misnamed (e.g. nsPrintJob::PrintPage actually prints a sheet which may contain multiple pages, so it really should be named PrintSheet now).

This feels a bit pedantic, but I think it's worth it for clarity/consistency of language & to reduce areas of ambiguity about places that are dealing with page numbers/counts vs. sheet numbers/counts.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1669774 part 1: Rename some nsPageSequenceFrame APIs and vars with s/page/sheet/for accuracy. r?TYLin

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1669774 part 2: Rename some APIs and variables for accuracy (s/page/sheet/) in nsPrintJob, nsPagePrintTimer, and nsDocumentViewer. r?TYLin

Depends on D92789

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/632236572730
part 1: Rename some nsPageSequenceFrame APIs and vars with s/page/sheet/for accuracy. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/f831fe50e3ba
part 2: Rename some APIs and variables for accuracy (s/page/sheet/) in nsPrintJob, nsPagePrintTimer, and nsDocumentViewer. r=TYLin

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/632236572730
https://hg.mozilla.org/mozilla-central/rev/f831fe50e3ba