Open Bug 1669762 Opened 4 years ago Updated 3 years ago

Rename some attributes in nsIWebBrowserPrint.idl with s/page/sheet/

Categories

(Core :: Printing: Setup, task)

task

Tracking

()

People

(Reporter: dholbert, Unassigned)

References

Details

(Whiteboard: [print2020])

As noted in XXXdholbert comments within nsIWebBrowserPrint.idl, we have some attributes there that currently have "page"-flavored naming, and which should in fact have "sheet"-flavored naming (since they correspond to a number of sheets, rather than pages).

The distinction being e.g.

  • if you have 7 pages in a 4-pages-per-sheet configuration, there are 7 pages but only 2 sheets
  • if you have 10 pages and the user asks to print a custom range 1-6, then there are 10 pages but only 6 sheets. Or if the user has 4-pages-per-sheet in this scenario, there'd be 2 sheets (the first one having pages 1-4, and the second one having pages 5-6)

Anyway; I'm filing this bug as a placeholder to rename these APIs once we're comfortable doing so. (I don't want to bitrot the print.js frontend code too much right now, since we're still actively doing uplifts and will be doing so for the forseeable future; and we don't have the help of a compiler to check for variables/usages that we missed on the frontend side.)

Severity: -- → S3
Depends on: 1660294

Specifically, we'll want s/page/sheet/ for these attributes:
printPreviewNumPages
printPreviewCurrentPageNumber

and these enum values:
PRINTPREVIEW_GOTO_PAGENUM
PRINTPREVIEW_PREV_PAGE
PRINTPREVIEW_NEXT_PAGE

Depends on: 1669774
Whiteboard: [print2020_v84]
Whiteboard: [print2020_v84] → [print2020_v85]
Whiteboard: [print2020_v85] → [print2020_v87]
Whiteboard: [print2020_v87] → [print2020]
You need to log in before you can comment on or make changes to this bug.