1669847 - Make Stencil instantiation use const references to the stencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

To make it easier to manage lifetimes of stencils, we should remove more cases where we may mutate the stencil during instantiation.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1669847 - Deduplicate bytecode while building Stencil. r?arai

Instead of waiting until instantiation, deduplicate the bytecode as soon as
we create the stencil. This lets the stencil become immutable sooner.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1669847 - Make ScopeStencil instantiation const. r?arai

Depends on D92827

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1669847 - Make ScriptStencil instantiation const. r?arai

Depends on D92828

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1669847 - Make StencilModuleMetadata instantiation const. r?arai

Depends on D92829

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1669847 - Make RegExpStencil instantiation const. r?arai

Depends on D92830

Comment 6

[Ted Campbell [:tcampbell]]

Attachment: Bug 1669847 - Make CompilationStencil instantiation const. r?arai

Depends on D92831

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52101621da0a
Deduplicate bytecode while building Stencil. r=arai
https://hg.mozilla.org/integration/autoland/rev/644420b101ea
Make ScopeStencil instantiation const. r=arai
https://hg.mozilla.org/integration/autoland/rev/337571ce1b87
Make ScriptStencil instantiation const. r=arai
https://hg.mozilla.org/integration/autoland/rev/afbd765c6935
Make StencilModuleMetadata instantiation const. r=arai
https://hg.mozilla.org/integration/autoland/rev/f7cec3c83d8a
Make RegExpStencil instantiation const. r=arai
https://hg.mozilla.org/integration/autoland/rev/e88890094825
Make CompilationStencil instantiation const. r=arai

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/52101621da0a
https://hg.mozilla.org/mozilla-central/rev/644420b101ea
https://hg.mozilla.org/mozilla-central/rev/337571ce1b87
https://hg.mozilla.org/mozilla-central/rev/afbd765c6935
https://hg.mozilla.org/mozilla-central/rev/f7cec3c83d8a
https://hg.mozilla.org/mozilla-central/rev/e88890094825

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/ca279e551454
Backed out 6 changesets as req by tcampbell for creating fuzz-blocker Bug 1670013. DONTBUILD a=backout

Comment 10

[Phabricator Automation]

Comment on attachment 9180276 [details]
Bug 1669847 - Deduplicate bytecode while building Stencil. r?arai

Revision D92827 was moved to bug 1670077. Setting attachment 9180276 [details] to obsolete.

Comment 11

[Ted Campbell [:tcampbell]]

I've added a fix to the fuzzing issue in Bug 1670077 and most the first patch from this bug to that one.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/582030c62bf7
Make ScopeStencil instantiation const. r=arai
https://hg.mozilla.org/integration/autoland/rev/412d0376ead5
Make ScriptStencil instantiation const. r=arai
https://hg.mozilla.org/integration/autoland/rev/a20885ccf659
Make StencilModuleMetadata instantiation const. r=arai
https://hg.mozilla.org/integration/autoland/rev/7035e72bd96b
Make RegExpStencil instantiation const. r=arai
https://hg.mozilla.org/integration/autoland/rev/3a5a129d7e71
Make CompilationStencil instantiation const. r=arai

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/582030c62bf7
https://hg.mozilla.org/mozilla-central/rev/412d0376ead5
https://hg.mozilla.org/mozilla-central/rev/a20885ccf659
https://hg.mozilla.org/mozilla-central/rev/7035e72bd96b
https://hg.mozilla.org/mozilla-central/rev/3a5a129d7e71