1670077 - Deduplicate bytecode while building Stencil.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

Deduplicate the bytecode while building Stencil so we don't have to mutate it during instantiation.

We also have to fix the ScriptData table lock since it relied on machinery in the ParseGlobal.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1670077 - Use ParseTask count to control AutoLockScriptData. r?jonco

The AutoLockScriptData mechanism currently skips locking if there are no
active parse globals. With Stencil, we no longer use the parse global but
would still like to have access to the script-data table. To do this, we
add a similar counter that tracks ParseTasks instead of parse globals.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1670077 - Deduplicate bytecode while building Stencil. r?arai

Instead of waiting until instantiation, deduplicate the bytecode as soon as
we create the stencil. This lets the stencil become immutable sooner.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cd7bf410b93
Use ParseTask count to control AutoLockScriptData. r=jonco
https://hg.mozilla.org/integration/autoland/rev/c330707328a4
Deduplicate bytecode while building Stencil. r=arai

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4cd7bf410b93
https://hg.mozilla.org/mozilla-central/rev/c330707328a4