Closed Bug 166993 Opened 22 years ago Closed 22 years ago

[typeaheadfind] gracefully handle quickly mashed chars on keyboard

Categories

(SeaMonkey :: Find In Page, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.2beta

People

(Reporter: aaronlev, Assigned: aaronlev)

References

Details

Attachments

(1 file, 2 obsolete files)

Right now if your mash your hands on the keyboard to get a lot of characters at
once, type ahead takes a while of beeping when it should give up more easily.

I can fix this by implementing both of these algorithms:

1. When a user types another character immediately after something else was
typed which wasn't found, and they haven't hit backspace, then we don't need to
search - we already know the search failed.

2. After 3-5 bad chars in a row, we could just disabled ourselves until a
timeout, or we could throw up a dialog describing what "just typing" in the
browser does - one more way to make us discoverable. Which would people prefer?
Blocks: isearch
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.2beta
I decided not to go with the dialog box, that was a dumb idea. This simple
solution, which just uses the normal status bar message for a cancelled find,
works well.
Comment on attachment 98087 [details] [diff] [review]
Counts the number of bad keys since the last match. If we reach 3, don't use any new keys for type ahead find until it gets cancelled by timeout, escape or other normal means

r=syd
Attachment #98087 - Flags: review+
Comment on attachment 98089 [details] [diff] [review]
Two more lines to make sure backspace still works correctly

r=syd
Attachment #98089 - Flags: review+
Attachment #98090 - Flags: review+
Comment on attachment 98090 [details] [diff] [review]
Use a const for the max number of bad keystrokes before we cancel

Syd gave verbal okay to change, carrying r=
Attachment #98089 - Attachment is obsolete: true
Attachment #98087 - Attachment is obsolete: true
Comment on attachment 98090 [details] [diff] [review]
Use a const for the max number of bad keystrokes before we cancel

+    if (-- mBadKeysSinceMatch < 0)

Loose the space between the -- operator and the variable.

sr=jst
Attachment #98090 - Flags: superreview+
Comment on attachment 98090 [details] [diff] [review]
Use a const for the max number of bad keystrokes before we cancel

a=rjesup@wgate.com
Attachment #98090 - Flags: approval+
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
vrfy'd fixed --beeping stops as does typeahead find, if i quickly type in a
bunch of random chars.
Status: RESOLVED → VERIFIED
Component: Keyboard: Navigation → Keyboard: Find as you Type
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: