166993 - [typeaheadfind] gracefully handle quickly mashed chars on keyboard

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect, P3)

Description

[Aaron Leventhal]

Right now if your mash your hands on the keyboard to get a lot of characters at
once, type ahead takes a while of beeping when it should give up more easily.

I can fix this by implementing both of these algorithms:

1. When a user types another character immediately after something else was
typed which wasn't found, and they haven't hit backspace, then we don't need to
search - we already know the search failed.

2. After 3-5 bad chars in a row, we could just disabled ourselves until a
timeout, or we could throw up a dialog describing what "just typing" in the
browser does - one more way to make us discoverable. Which would people prefer?

Comment 1

[Aaron Leventhal]

Attachment: Counts the number of bad keys since the last match. If we reach 3, don't use any new keys for type ahead find until it gets cancelled by timeout, escape or other normal means

I decided not to go with the dialog box, that was a dumb idea. This simple
solution, which just uses the normal status bar message for a cancelled find,
works well.

Comment 2

[Syd Logan]

Comment on attachment 98087 [details] [diff] [review]
Counts the number of bad keys since the last match. If we reach 3, don't use any new keys for type ahead find until it gets cancelled by timeout, escape or other normal means

r=syd

Comment 3

[Aaron Leventhal]

Attachment: Two more lines to make sure backspace still works correctly

Comment 4

[Syd Logan]

Comment on attachment 98089 [details] [diff] [review]
Two more lines to make sure backspace still works correctly

r=syd

Comment 5

[Aaron Leventhal]

Attachment: Use a const for the max number of bad keystrokes before we cancel

Comment 6

[Aaron Leventhal]

Comment on attachment 98090 [details] [diff] [review]
Use a const for the max number of bad keystrokes before we cancel

Syd gave verbal okay to change, carrying r=

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 98090 [details] [diff] [review]
Use a const for the max number of bad keystrokes before we cancel

+    if (-- mBadKeysSinceMatch < 0)

Loose the space between the -- operator and the variable.

sr=jst

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 98090 [details] [diff] [review]
Use a const for the max number of bad keystrokes before we cancel

a=[e-mail]

Comment 9

[Aaron Leventhal]

checked in

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed --beeping stops as does typeahead find, if i quickly type in a
bunch of random chars.