1670416 - webdav acls not checked during setup

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, enhancement)

Description

[Дилян Палаузов]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

With 82.0b2 I click "+ add calendar”, enter as server https://aaa.bapha.be, without user name, do Offline Support. → Find Calendars.

TB finds three calendars. I click on Properties.

For anonymous access the calendars are read-only, but the Properties do not show autmatic a tick before 'Read Only'. Neither do the WebDAV calls utilize the WebDAV ACL.

Actual results:

On setting up calendar use WebDAV ACL to find out, if a calendar is read-only and fill this in the Calendar Properties

Comment 1

[Дилян Палаузов]

Now for https://aaa.bapha.be two calendar-home-sets are returned, so to test this first https://bugzilla.mozilla.org/show_bug.cgi?id=1670415 has to be fixed.

Comment 2

[Magnus Melin [:mkmelin]]

xref bug 306495

Should hook up calACLUtils.jsm where appropriate I guess.

Comment 3

[Martin Schröder [:mschroeder]]

Has this been fixed with bug 1665203 and is therefore a duplicate?

Comment 4

[Дилян Палаузов]

Per bug 1714586 the Calendar component overall does not work, so I cannot test if this has been fixed.

Comment 5

[Дилян Палаузов]

It seems that TB 91.0a1 does it right.

Comment 7

[Дилян Палаузов]

TB91-release does not make HTTP calls, during calendars setup, to find the ACL. In turn it does not mark as READ-ONLY calendars, which are READ-ONLY. This is a regression.

Comment 8

[Magnus Melin [:mkmelin]]

Lasana, can you check this?

Comment 9

[Lasana Murray]

Attachment: Bug 1670416 - Detect read-only acl privs for C:calendar-home-set. r=darktrojan

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/81e03162ca75
Detect read-only acl privs for C:calendar-home-set. r=darktrojan

Comment 12

[Magnus Melin [:mkmelin]]

Please request 91 uplift.

Comment 13

[Lasana Murray]

Comment on attachment 9237774 [details]
Bug 1670416 - Detect read-only acl privs for C:calendar-home-set. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Some caldav calendars will not be marked as read-only resulting in an error if the user tries to write to them.
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky): Should not be too much, just an addition to the properties requested.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9237774 [details]
Bug 1670416 - Detect read-only acl privs for C:calendar-home-set. r=darktrojan

[Triage Comment]
Approved for esr91

Comment 15

[Дилян Палаузов]

To my knowledge, TB91 cannot manage (create, delete, edit) the calendars theirselves, it can only create, delete edit events in existing calendar. For the read-only detection it is therefore only significant, if the calendar-URL is read-only. Why does the change title state, that the acl privs on the calendar-home-set are checked?

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 91.2.0:
https://hg.mozilla.org/releases/comm-esr91/rev/be2b4f5e1c37