1670436 - Text does not climb into error window

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Roman Deev]

Attachment: Window.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

After painting Firefox in the window that appears does not fit the text, and the window can not be expanded.

Comment 1

[Gabriele Svelto [:gsvelto]]

This is a good first bug. The checkboxes are being created and setup here.

We should either wrap the text or widen the window so that it's not truncated.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Patch reproducing the issue

Apply this patch before building Firefox to reproduce the issue in a local build.

Comment 3

[Blessing Peters]

Hello, I am an outreachy applicant and would love to work on this bug.

Comment 4

[Gabriele Svelto [:gsvelto]]

Hello Blessing and welcome, do you already have set up a Firefox build on your mac? If you do I'll assign you to the bug directly and help you fix it, if you don't then I'll first walk you through setting up a Firefox build.

Comment 5

[Abhishek[: unavailable till 11 May]]

Sir, I have my setup ready, can I work on this, if Peters's setup is not ready?

Comment 6

[Blessing Peters]

(In reply to Gabriele Svelto [:gsvelto] from comment #4)

Hello Blessing and welcome, do you already have set up a Firefox build on your mac? If you do I'll assign you to the bug directly and help you fix it, if you don't then I'll first walk you through setting up a Firefox build.

Thank you for the feedback, I have my Firefox build ready and I will really appreciate to the opportunity to work with you on this.

Comment 7

[Gabriele Svelto [:gsvelto]]

(In reply to Blessing Peters from comment #6)

Thank you for the feedback, I have my Firefox build ready and I will really appreciate to the opportunity to work with you on this.

I have assigned the bug to you. The first step is to reproduce the issue and study the code that causes it:

1. Apply the patch in comment 2 to Firefox code
2. Make sure that your mozconfig file contains this line, this is required for the crash reporter to be built:

ac_add_options --enable-crashreporter

3. Build Firefox w/ the patch applied
4. Launch Firefox with the following command, this will ensure that the crash reporter is used:

./mach run --enable-crash-reporter

5. Browse to about:crashparent, this will crash the browser and display the crash reporter client. This should display the truncated string.

Comment 8

[Gabriele Svelto [:gsvelto]]

(In reply to Abhishek from comment #5)

Sir, I have my setup ready, can I work on this, if Peters's setup is not ready?

I'm assigning the bug to her because she requested it first, fortunately there are several other good first bugs to pick from.

Comment 9

[Gabriele Svelto [:gsvelto]]

One additional note: please join the #crashreporting channel on chat.mozilla.org, you'll find me there in case you need help.

Comment 10

[Blessing Peters]

(In reply to Gabriele Svelto [:gsvelto] from comment #7)

(In reply to Blessing Peters from comment #6)

Thank you for the feedback, I have my Firefox build ready and I will really appreciate to the opportunity to work with you on this.

I have assigned the bug to you. The first step is to reproduce the issue and study the code that causes it:

1. Apply the patch in comment 2 to Firefox code
2. Make sure that your mozconfig file contains this line, this is required for the crash reporter to be built:

ac_add_options --enable-crashreporter

3. Build Firefox w/ the patch applied
4. Launch Firefox with the following command, this will ensure that the crash reporter is used:

./mach run --enable-crash-reporter

5. Browse to about:crashparent, this will crash the browser and display the crash reporter client. This should display the truncated string.

Will get right to it. thank you

Comment 11

[Blessing Peters]

(In reply to Gabriele Svelto [:gsvelto] from comment #9)

One additional note: please join the #crashreporting channel on chat.mozilla.org, you'll find me there in case you need help.

Okay then

Comment 12

[Blessing Peters]

Attachment: Bug 1670436 - Prevent localized strings from being truncated in the crash reporter client r?gsvelto

Comment 13

[Blessing Peters]

Attachment: Bug 1670436 - Revert message used to replicate bug r?gsvelto

Depends on D172823

Comment 14

[Francesco Lodolo [:flod]]

Note: there was a much older bug reported for this (bug 528800).

@gabriele
Can you confirm if that would be fixed here and mark as a dupe?

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6b709a45852
Prevent localized strings from being truncated in the crash reporter client r=gsvelto

Comment 16

[Gabriele Svelto [:gsvelto]]

(In reply to Francesco Lodolo [:flod] from comment #14)

Note: there was a much older bug reported for this (bug 528800).

@gabriele
Can you confirm if that would be fixed here and mark as a dupe?

Yes, it's a dupe, I'll close it.

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c6b709a45852