Closed Bug 1670574 Opened 4 years ago Closed 4 years ago

Add a close button to the horizontal bar when attachment is viewed

Categories

(bugzilla.mozilla.org :: General, enhancement)

Other
Other
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: ishikawa, Assigned: glob)

Details

Attachments

(2 files)

Hi,

Thank you for providing the great bug reporting mechanism. I use it quite often to view and report bugs for Thunderbird.

Recent change in bugzilla.mozilla.org has made it possible to view the outline of graphics attachment inline (I mean in side the comment box) which is neat.

We can also click on the shown outline to get the full detailed view.
This is nice.

However, that is where I notice a problem. I was not quite sure how to close the enlarge detailed view for quite a while.

I am using a rather large 4K display and when the attachment, say, graphics is shown, I was not sure how to close it. (A certain UI for an SNS service today has (x) button on the left of the graphics to close it and return to the previous view.)

I added an attachment of the screen when I opened a graphics attachment. I also mark the positions where maybe an explicit CLOSE button "[x]" can be placed.

To be frank, I was so interested in looking at the content (the graphics), it took me quite a while to figure out there is horizontal bar ABOVE the graphics to begin with.

And by sheer accident, I found out that clicking on the horizontal bar seems to close the detailed attachment view.

It would be great to add "[x]" on the horizontal bar, AND/OR add a close button "(X)" on the left of graphics. ANY HARD TO MISS visual indicator to trigger the closing and returning to the previous view is good.

TIA

There is a close button, but it's hidden by the header – oops!

Assignee: nobody → glob

Note that clicking anywhere on the darkened background area to the left and right of the image will also close it.

Attached file GitHub Pull Request

Merged to master.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

(In reply to :glob 🎈 from comment #1)

There is a close button, but it's hidden by the header – oops!

Whoa!

(In reply to :glob 🎈 from comment #2)

Note that clicking anywhere on the darkened background area to the left and right of the image will also close it.

That was not obvious. Well, the exposed button should solve confusion, definitely. :-)

(In reply to ISHIKAWA, Chiaki from comment #6)

(In reply to :glob 🎈 from comment #2)

Note that clicking anywhere on the darkened background area to the left and right of the image will also close it.

That was not obvious. Well, the exposed button should sovve confusion, definitely. :-)

I just confirmed it works now. I see [close] button. Thanks.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: