1670660 - Edit Link Properties of Hyperlink no longer set initial focus

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Ian Eales]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36 Edg/86.0.622.38

Steps to reproduce:

In a new message, click in a Hyperlink & press Ctrl-K to edit

Actual results:

Dialog opens, but link text is not highlighted as in previous versions

Expected results:

Link text highlighted to allow easy insertion of new link on clipboard.

Comment 1

[Magnus Melin [:mkmelin]]

Probably from textbox removal.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1670660_link_props_input_focus.patch

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9181729 [details] [diff] [review]
bug1670660_link_props_input_focus.patch

Review of attachment 9181729 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes it, thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4809e45bee28
at dialog startup select the link URL in the link properties dialog. r=aleca DONTBUILD

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9181729 [details] [diff] [review]
bug1670660_link_props_input_focus.patch

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: minor - link text not selected on dialog startup
Testing completed (on c-c, etc.): on beta
Risk to taking this patch (and alternatives if risky): not risky

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9181729 [details] [diff] [review]
bug1670660_link_props_input_focus.patch

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/93b55d9bc22c

Comment 8

[WaltS48 [:walts48]]

Attachment: link-edit.PNG

So the steps to reproduce are?

In an open composition window select Insert > Link, or use Ctrl+K to open the Link Properties dialog.
Enter some text in the top field.
Enter the link in the Link Location field.
Click "OK".

Decide you want to edit the text, not the link.

Select the link and use Ctrl+K to open it.
The text field is still not editable, but the link field is editable.

The user can edit the text in the the composition window with the dialog closed.

Testing the 78.4.1 release candidate on Windows 10.

Comment 9

[Magnus Melin [:mkmelin]]

The change is that the URL is now (again) selected/highlighted, so you can just delete all of it if you want.