1670822 - Extend the menus API to attachments in the compose window

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Geoff Lankow (:darktrojan)]

The menus API should cover a lot more menus. In this bug I'll add the context menu when clicking on attachments in the composition window, and do some refactoring to make adding more menus easier.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1670822 - Add the composition window attachments menu to the menus API. r?mkmelin

Adds a "compose_attachments" context to the API, and a list of the selected attachments when the menu is used.

This is complicated by the way attachments in APIs work, we have to capture the firing event in the child process and transform the attachments.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1670822 - Add a size parameter to the API attachment representation.

I should have done this from the outset, but didn't think it was important.

Depends on D93285

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1670822 - Overhaul the test browser_ext_menus.js. r?mkmelin

This test was originally only testing our additions to the standard menus API. I've heavily refactored it to make adding new tests easier.

Depends on D93286

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e0d1dc4a79f8
Add the composition window attachments menu to the menus API. r=mkmelin
https://hg.mozilla.org/comm-central/rev/a3cf6c7f396f
Add a size parameter to the API attachment representation. r=john.bieling
https://hg.mozilla.org/comm-central/rev/67b5bcc96b4d
Overhaul the test browser_ext_menus.js. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9181155 [details]
Bug 1670822 - Add the composition window attachments menu to the menus API. r?mkmelin

[Approval Request Comment]
User impact if declined: This is a useful integration point for extensions
Testing completed (on c-c, etc.): Landed in 83, been through a full beta cycle
Risk to taking this patch (and alternatives if risky): Not risky

(request is for all 3 patches)

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9181155 [details]
Bug 1670822 - Add the composition window attachments menu to the menus API. r?mkmelin

[Triage Comment]
Mailextension API updates.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/2cbe08567219
https://hg.mozilla.org/releases/comm-esr78/rev/c2b08222db8a
https://hg.mozilla.org/releases/comm-esr78/rev/35336bb55687