1670832 - Enable the menus API in messages being composed

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, task)

Description

[Geoff Lankow (:darktrojan)]

If an extension has the compose permission, it should be able to see things like selected text, image URLs (not that they're much use) when using context menus in messages being composed.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1670832 - Upgrade browser_ext_menus.js some more. r?mkmelin

I'm improving this test to prove that the menu in the compose window does the same things as the main context menu, with respect to WebExtensions.
More big changes to the menus code are in the pipeline as well, so locking down the behaviour with a test is good.

Adds tests for the selection, image, and link contexts. Adds tests for other places the main context menu appears.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1670832 - Enable the menus API in messages being composed. r?mkmelin

Depends on D94213

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3117239e6d5e
Upgrade browser_ext_menus.js some more. r=mkmelin
https://hg.mozilla.org/comm-central/rev/205620c78120
Enable the menus API in messages being composed. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4fd365d76ca4
follow-up - fix formatting error. rs=linting DONTBUILD

Comment 5

[Teal Dulcet [:tdulcet] (TB Council)]

This likely also fixes bug 1656506.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9182790 [details]
Bug 1670832 - Upgrade browser_ext_menus.js some more. r?mkmelin

[Approval Request Comment]
Api fixes. This and the other patch

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9182790 [details]
Bug 1670832 - Upgrade browser_ext_menus.js some more. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9182791 [details]
Bug 1670832 - Enable the menus API in messages being composed. r?mkmelin

[Triage Comment]
(to go with the first patch)
Already landed on beta.
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.6.0:
https://hg.mozilla.org/releases/comm-esr78/rev/b5a999234b74
https://hg.mozilla.org/releases/comm-esr78/rev/258fb14122e9
https://hg.mozilla.org/releases/comm-esr78/rev/9575a9f76311