Closed Bug 1670908 Opened 4 years ago Closed 4 years ago

Non-recommended add-ons, themes, language packs and dictionaries are not supported by the RTAMO flow

Categories

(Firefox :: Messaging System, defect, P1)

Firefox 83
defect

Tracking

()

VERIFIED FIXED
83 Branch
Iteration:
83.2 - Oct 5 - Oct 18
Tracking Status
firefox83 + verified

People

(Reporter: alexandru.cornestean, Assigned: pdahiya)

References

Details

Attachments

(4 files)

[Affected versions]:

83.0a1/20201012152719

[Affected platforms]:

Windows 10 Pro 64-bit
Ubuntu 16.04 LTS
macOS Catalina 10.15

[Prerequisites]:

Initiate the RTAMO flow and reach the onboarding page for several non-recommended add-ons, themes, language packs and dictionaries.

[Steps to reproduce]:

  1. Reach the RTAMO first run page
  2. Notice the onBoarading card will display a blank icon and placeholder text for the above mentioned supplements
  3. Click on the “Add the Extension” blue button
  4. Observe that nothing happens i.e. the installation process is not initiated

[Expected results]:

  1. The onBoarding card should properly display the supplement icon and name
  2. The installation process should initiate when clicking the “Add the Extension” blue button

[Actual results]:

Blank icons and placeholder text are displayed for the add-on icon and name.
The add-ons cannot be installed.

NOTES:

  1. Recommended add-on icons and titles are properly displayed on the onBoarding card and they can be installed.
  2. Several errors are displayed in the browser console when attempting to initiate the RTAMO flow from the mentioned supplements and install them (see attached screenshots).
Attached image error 1.png
Attached image error 2.png
Blocks: 1659169
Assignee: nobody → pdahiya
Severity: -- → S2
Iteration: --- → 83.2 - Oct 5 - Oct 18
Priority: -- → P1
Blocks: 1468680
No longer blocks: multistage-aw

Displaying RTAMO welcome page only for recommended add-ons (https://addons.mozilla.org/en-US/firefox/search/?promoted=recommended&sort=random) is the expected flow. Fix of below issue should expand it to include badged add-ons

https://github.com/mozilla/addons-server/issues/15732

Patch attached to this bug fixes about:welcome to show default welcome flow for non-recommended add-ons.

Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b5aa987e4a4 Display default welcome when addon info not available r=Mardak
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

How does this handle add-ons not found through AMO search? AddonRepository.getAddonsByIDs() can return an empty array when AMO search API doesn't raise an error but no results are returned. It's an unlikely scenario, but it could happen if somehow the add-on is no longer public.

(In reply to Mathieu Pillard [:mat] from comment #8)

How does this handle add-ons not found through AMO search? AddonRepository.getAddonsByIDs() can return an empty array when AMO search API doesn't raise an error but no results are returned. It's an unlikely scenario, but it could happen if somehow the add-on is no longer public.

Empty array return from await AddonRepository.getAddonsByIDs is going to behave same as any other error returned by API and will display default welcome flow

https://searchfox.org/mozilla-central/source/browser/components/newtab/aboutwelcome/AboutWelcomeChild.jsm#257
https://searchfox.org/mozilla-central/source/browser/components/newtab/aboutwelcome/AboutWelcomeParent.jsm#207

Hello,

I’ve checked the fix on the latest Nightly (83.0a1/20201015215335) on Windows 10 Pro 64-bit with several badged add-ons, including here the By Firefox, Sponsored and Verified add-ons. These are the results:

  1. By Firefox
  • Facebook Container – the RTAMO welcome page is displayed
  1. Sponsored (with the Verified badge)
  • AdBlock for Firefox – the default multistage a:w page is displayed
  • Linguix.com Grammar and Spell Checker – the default multistage a:w page is displayed
  1. Verified
  • Sticky Ducky - clean the fixed elements - the default multistage a:w page is displayed

I haven’t tried with recommended themes as I’ve learned that these are served through a special collection and are not created as a DiscoveryItem and thus not applicable for RTAMO.

Also language tools such as language packs and dictionaries are not badged as far as I can tell and thus not in scope for the RTAMO flow. Is this correct?

Are these results the intended ones?

Flags: needinfo?(pdahiya)

I haven’t tried with recommended themes as I’ve learned that these are served through a special collection and are not created as a DiscoveryItem and thus not applicable for RTAMO.

FYI starting from next week (after our Thursday 22nd push, that should be finished around 18:00 UTC) recommended themes will also work, as we're changing the source of data to use recommended data.

(In reply to Alex Cornestean from comment #10)

Hello,

I’ve checked the fix on the latest Nightly (83.0a1/20201015215335) on Windows 10 Pro 64-bit with several badged add-ons, including here the By Firefox, Sponsored and Verified add-ons. These are the results:

  1. By Firefox
  • Facebook Container – the RTAMO welcome page is displayed
  1. Sponsored (with the Verified badge)
  • AdBlock for Firefox – the default multistage a:w page is displayed
  • Linguix.com Grammar and Spell Checker – the default multistage a:w page is displayed
  1. Verified
  • Sticky Ducky - clean the fixed elements - the default multistage a:w page is displayed

I haven’t tried with recommended themes as I’ve learned that these are served through a special collection and are not created as a DiscoveryItem and thus not applicable for RTAMO.

Also language tools such as language packs and dictionaries are not badged as far as I can tell and thus not in scope for the RTAMO flow. Is this correct?

Are these results the intended ones?

@acornestean LGTM! as of now most of the add-ons in https://addons.mozilla.org/en-US/firefox/search/?promoted=recommended&sort=random should use custom RTAMO welcome page.
As commented by @mat in #c11 , the list should be much more reliable with fix of https://github.com/mozilla/addons-server/issues/15732 and should include https://addons.mozilla.org/en-US/firefox/search/?page=1&promoted=badged&sort=random . Thanks!

Flags: needinfo?(pdahiya)

Hello,

I’ve attempted to verify the bug once more on the latest Beta Dev Ed (83.0b2/20201020173725), since issue https://github.com/mozilla/addons-server/issues/15732 has been fixed.

To test on -dev, I’ve set several prefs in order to allow for addons to be installed from -dev and also to point Firefox to -dev. These are the modified preferences:

  • extensions.getAddons.get.url to point to -dev
  • xpinstall.signatures.dev-root to true
  • extensions.webapi.testing to true
  • xpinstall.signatures.required to false

The following add-ons have been used to test the RTAMO flow and the corresponding results:

Recommended - https://addons-dev.allizom.org/en-US/firefox/addon/bubbles-for-mozilla-appr/ - the RTAMO welcome page is displayed

Sponsored - https://addons-dev.allizom.org/en-US/firefox/addon/a-test-for-spotlight-addons/ - the RTAMO welcome page is displayed

Verified - https://addons-dev.allizom.org/en-US/firefox/addon/more-optional-permissions/ - the RTAMO welcome page is displayed

By Firefox - https://addons-dev.allizom.org/en-US/firefox/addon/devhub-listed-ext-04-30/ - the RTAMO welcome page is displayed

Recommended theme - not collection - https://addons-dev.allizom.org/en-US/firefox/addon/legacy-view-remove-theme/ - the RTAMO welcome page is displayed and the theme is applied

Recommended theme - from collection - https://addons-dev.allizom.org/en-US/firefox/addon/iarba/ - the RTAMO welcome page is displayed and the theme is applied

Not promoted - https://addons-dev.allizom.org/en-US/firefox/addon/my-first-extension/ - the default multistage a:w page is displayed

Based on these results I believe this issue is fixed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: