1671477 - Add profile markers to help diagnose failures in WMFVideoMFTManager

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Diagnosing performance issues in the wild due to failures in WMF (hardware) decoding can be difficult. It would be useful to have profile markers to enrich profile runs where such failures take place.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1671477 - Add profile markers and logs to help diagnose failures in WMF decoding. r?alwu

We have reports of VPx WMF failures in the wild causing performance issues, but
it can be hard to detect these failures. Having explicit markers in the profiler
with more information will make it easier to see if users are running into these
issues if they can provide profiles. I've also added logs to enrich cases where
we will use logging to debug.

Driveby fix a comment that says we're asserting when we no longer are.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebe668f9d3dd
Add profile markers and logs to help diagnose failures in WMF decoding. r=alwu

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset ebe668f9d3dd (bug 1671477) for Build bustages. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318872503&repo=autoland&lineNumber=17349

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=ebe668f9d3dda4764a8bbe73bbf7414200a7ce98

Backout:
https://hg.mozilla.org/integration/autoland/rev/7da5b6c42372a3415ff14de903dd4d30923f7060

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b64cb312c05b
Add profile markers and logs to help diagnose failures in WMF decoding. r=alwu

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/802898bbe773
Fix warning in a trivial cast in wgpu on Android r=padenot. CLOSED TREE

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/802898bbe773
Fix warning in a trivial cast in wgpu on Android r=padenot. CLOSED TREE

Looks like that one it from bug 1622846 and got accidentally attributed here.

Comment 7

[Dorel Luca [:dluca]]

This should fix that.
https://hg.mozilla.org/integration/autoland/rev/cf56faef2700167e3951fcd674cc8410495a6353

Sorry for the confusion I made.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40b1107e9702
Add profile markers and logs to help diagnose failures in WMF decoding. r=alwu

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eec6220e1fd
Backed out changeset b64cb312c05b for Build bustage on Android. CLOSED TREE

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/40b1107e9702