1622846 - Update WebGPU IDL to the upstream changes

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task, P3)

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: WebGPU bindings update to the spec

Updates wgpu code as well as our WebIDL bindings.

The wgpu-types is a new component crate that has public types available to
Rust applications that target the Web directly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea8f9dbcce01
WebGPU bindings update to the spec r=jgilbert,webidl,smaug

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ea8f9dbcce01

Comment 4

[Dzmitry Malyshau [:kvark]]

Attachment: Fix WebGPU AttributeSet

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2943e7e23407
Fix WebGPU AttributeSet r=webidl,smaug

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2943e7e23407

Comment 7

[Dzmitry Malyshau [:kvark]]

Attachment: Update WebGPU TextureDescriptor API

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65bac630303a
Update WebGPU TextureDescriptor API r=jgilbert,webidl,smaug

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/65bac630303a

Comment 10

[Dzmitry Malyshau [:kvark]]

Attachment: WebGPU dummy destroy() and optional stencil states

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27de02d808be
WebGPU dummy destroy() and optional stencil states r=webidl,smaug

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/27de02d808be

Comment 13

[Dzmitry Malyshau [:kvark]]

Attachment: Update WebGPU IDL type definitions

Using typedefs with enforced ranges

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73ef509b8589
Update WebGPU IDL type definitions r=webidl,smaug

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/73ef509b8589

Comment 16

[Dzmitry Malyshau [:kvark]]

Attachment: WebGPU new mapping API

WIP update

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13bb2d007f1f
WebGPU new mapping API r=webidl,jgilbert,smaug

Comment 18

[Dzmitry Malyshau [:kvark]]

Attachment: Fix warning in a trivial cast in wgpu on Android

Comment 19

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Heads up that I think the warning fix got landed against Bug 1671477 (https://hg.mozilla.org/integration/autoland/rev/802898bbe773).

Comment 20

[Dorel Luca [:dluca]]

Bryce, you are correct, fix it now.
Sorry for that

Comment 21

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Dorel Luca [:dluca] from comment #20)

Bryce, you are correct, fix it now.
Sorry for that

No problem and thanks!

Comment 22

[Dorel Luca [:dluca]]

Backed out changeset 13bb2d007f1f (bug 1622846) for Build bustage on android. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319016840&repo=autoland&lineNumber=18951

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=13bb2d007f1f159adc7d51902e86b2b0bc703aba

Backout:
https://hg.mozilla.org/integration/autoland/rev/b2663efeb9516b1a7cdc76408cb950d84d20e3b3

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ea6b52780c0
WebGPU new mapping API r=webidl,jgilbert,smaug

Comment 24

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7ea6b52780c0

Comment 25

[Dzmitry Malyshau [:kvark]]

This has relanded now with a proper fix

Comment 26

[Dzmitry Malyshau [:kvark]]

Attachment: Serialize WebGPU descriptors via Serde for IPC

This PR updates wgpu to the latest and changes the way we pass object descriptors to the GPU process.
Instead of trying to convert them between DOM-CPP-IPDL-FFI-Rust, we now do DOM-FFI-Rust
and serialize them by serde into ipc::ByteBuf objects.

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdd3d7eb5927
Serialize WebGPU descriptors via Serde for IPC r=jgilbert,webidl,smaug

Comment 28

[Natalia Csoregi [:nataliaCs]]

Backed out for linux bustage on gfx/wgpu/wgpu-types/src/lib.rs

backout: https://hg.mozilla.org/integration/autoland/rev/12af9db37d149203ca6e6f605bbfa2e7a9160951

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2Cbb&revision=bdd3d7eb59276188d6dee4f542c8f0e772b5ddef

failure log: https://treeherder.mozilla.org/logviewer?job_id=320996266&repo=autoland&lineNumber=17170

[task 2020-11-06T22:25:32.076Z] 22:25:32 INFO - Compiling audioipc v0.2.5 (/builds/worker/checkouts/gecko/media/audioipc/audioipc)
[task 2020-11-06T22:25:32.080Z] 22:25:32 INFO - Running CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/media/audioipc/audioipc CARGO_PKG_AUTHORS='Matthew Gregan <[e-mail]>:Dan Glastonbury <[e-mail]>' CARGO_PKG_DESCRIPTION='Remote Cubeb IPC' CARGO_PKG_HOMEPAGE= CARGO_PKG_NAME=audioipc CARGO_PKG_REPOSITORY= CARGO_PKG_VERSION=0.2.5 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=2 CARGO_PKG_VERSION_PATCH=5 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/builds/worker/workspace/obj-build/debug/deps:/builds/worker/fetches/rustc/lib:/builds/worker/workspace/obj-build/dist/bin:/builds/worker/fetches/gcc/lib64:/builds/worker/fetches/gcc/lib32:/builds/worker/fetches/gcc/lib' /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name audioipc --edition=2018 media/audioipc/audioipc/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=1 -C panic=abort -C debuginfo=2 -C debug-assertions=on -C metadata=1f1f9bd052ec8c5a -C extra-filename=-1f1f9bd052ec8c5a --out-dir /builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/checkouts/gecko/build/cargo-linker -L dependency=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/obj-build/debug/deps --extern audio_thread_priority=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libaudio_thread_priority-80410f89d794b15a.rlib --extern bincode=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libbincode-701b372b07ab812e.rmeta --extern bytes=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libbytes-f610da95b08c3fd8.rmeta --extern cubeb=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libcubeb-63f19207529f9307.rmeta --extern error_chain=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/liberror_chain-b4244c3af177f060.rmeta --extern futures=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libfutures-1224745a9ab26f59.rmeta --extern iovec=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libiovec-016c076fb7841f09.rmeta --extern libc=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/liblibc-7c17ac60d572d0c4.rmeta --extern log=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/liblog-7fee9b05e7ad7e60.rmeta --extern memmap=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libmemmap-c5621324ed5fdfa4.rmeta --extern mio=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libmio-f1bc051a1f721210.rmeta --extern mio_uds=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libmio_uds-fa8b9a439f21d0d7.rmeta --extern serde=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libserde-3fe387c1918e0335.rmeta --extern serde_derive=/builds/worker/workspace/obj-build/debug/deps/libserde_derive-846fd224bf9d2aed.so --extern tokio=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libtokio-e400ffe0fbfaa934.rmeta --extern tokio_io=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libtokio_io-de032140cf8631cd.rmeta --extern tokio_reactor=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libtokio_reactor-da83fbccc97878c1.rmeta -C opt-level=2 -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings -C codegen-units=1 -L native=/usr/lib/x86_64-linux-gnu
[task 2020-11-06T22:25:32.081Z] 22:25:32 INFO - error: unknown lint: broken_intra_doc_links
[task 2020-11-06T22:25:32.081Z] 22:25:32 INFO - --> gfx/wgpu/wgpu-types/src/lib.rs:9:10
[task 2020-11-06T22:25:32.081Z] 22:25:32 INFO - |
[task 2020-11-06T22:25:32.082Z] 22:25:32 INFO - 9 | #![allow(broken_intra_doc_links)]
[task 2020-11-06T22:25:32.082Z] 22:25:32 INFO - | ^^^^^^^^^^^^^^^^^^^^^^
[task 2020-11-06T22:25:32.082Z] 22:25:32 INFO - |
[task 2020-11-06T22:25:32.083Z] 22:25:32 INFO - = note: -D unknown-lints implied by -D warnings
[task 2020-11-06T22:25:32.083Z] 22:25:32 INFO - warning: ignoring -C extra-filename flag due to -o flag
[task 2020-11-06T22:25:32.083Z] 22:25:32 ERROR - error: aborting due to previous error
[task 2020-11-06T22:25:32.083Z] 22:25:32 INFO - error: could not compile wgpu-types.
[task 2020-11-06T22:25:32.100Z] 22:25:32 INFO - Caused by:
[task 2020-11-06T22:25:32.101Z] 22:25:32 INFO - process didn't exit successfully: CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/gfx/wgpu/wgpu-types CARGO_PKG_AUTHORS='wgpu developers' CARGO_PKG_DESCRIPTION='WebGPU types' CARGO_PKG_HOMEPAGE='https://github.com/gfx-rs/wgpu' CARGO_PKG_NAME=wgpu-types CARGO_PKG_REPOSITORY='https://github.com/gfx-rs/wgpu' CARGO_PKG_VERSION=0.6.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=6 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/builds/worker/workspace/obj-build/debug/deps:/builds/worker/fetches/rustc/lib:/builds/worker/workspace/obj-build/dist/bin:/builds/worker/fetches/gcc/lib64:/builds/worker/fetches/gcc/lib32:/builds/worker/fetches/gcc/lib' /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name wgpu_types --edition=2018 gfx/wgpu/wgpu-types/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=1 -C panic=abort -C debuginfo=2 -C debug-assertions=on --cfg 'feature="replay"' --cfg 'feature="serde"' --cfg 'feature="trace"' -C metadata=39cb380cd662b16a -C extra-filename=-39cb380cd662b16a --out-dir /builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/checkouts/gecko/build/cargo-linker -L dependency=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/obj-build/debug/deps --extern bitflags=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libbitflags-fd3f1da72d9c7eb8.rmeta --extern serde=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/debug/deps/libserde-3fe387c1918e0335.rmeta -C opt-level=2 -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings -C codegen-units=1 (exit code: 1)
[task 2020-11-06T22:25:32.101Z] 22:25:32 INFO - warning: build failed, waiting for other jobs to finish...

Comment 29

[Dzmitry Malyshau [:kvark]]

D'oh, it's really unfortunate to revert and fail for this reason. Rust renamed a lint. If we use the old name, Gecko will break later. I thought we can use the new name, and apparently not.

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c119cd84cd1
Serialize WebGPU descriptors via Serde for IPC r=jgilbert,webidl,smaug

Comment 31

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5c119cd84cd1

Comment 32

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #27)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdd3d7eb5927
Serialize WebGPU descriptors via Serde for IPC r=jgilbert,webidl,smaug

== Change summary for alert #27550 (as of Sat, 07 Nov 2020 21:21:43 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
0.31%	installer size		osx-cross		79,057,025.33 -> 79,299,714.25

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27550

Comment 33

[Dzmitry Malyshau [:kvark]]

Attachment: Update WebGPU API with wgpu

This is another WebGPU API update, it picks up a lot of changes that were made recently:

• new bind group layout
• new render pipeline descriptor
• new vertex formats
• limits
• compressed texture formats
• index format
• query sets
• and more small ones!

It also brings in the updated gfx/wgpu to support these API changes.

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c0c723b0a0e
Update WebGPU API with wgpu r=jgilbert,webidl,smaug

Comment 35

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 0c0c723b0a0e (bug 1622846) for build bustages in Device.h.
https://hg.mozilla.org/integration/autoland/rev/22ae0b952f66f2bd8f9f28a6a41fe3291d161e8a

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=cZVLFHZHTBGti-gtUFGLBA.0&revision=2e8859b2c1f8beec665aab057c56b8be50168f66

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=332089476&repo=autoland&lineNumber=6869

Comment 36

[Dzmitry Malyshau [:kvark]]

This is a very unfortunate failure, since it only manifests in Linux GCC build, and nowhere else...
I wish we could instead just land a patch to this, instead of backing out this huge change.
Anyhow, this is now re-landing with a fix.

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7ffb7e2b573
Update WebGPU API with wgpu r=jgilbert,webidl,smaug

Comment 38

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d7ffb7e2b573

Comment 39

[Josh Groves]

Attachment: Bug 1622846 - Use `view` instead of `attachment` to match upstream WebIDL r=kvark

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dad4502fd1e7
Use `view` instead of `attachment` to match upstream WebIDL r=kvark,emilio

Comment 41

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dad4502fd1e7

Comment 42

[Dzmitry Malyshau [:kvark]]

Attachment: Rename WebGPU OUTPUT_ATTACHMENT to RENDER_ATTACHMENT

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbc424d38040
Rename WebGPU OUTPUT_ATTACHMENT to RENDER_ATTACHMENT r=webidl,smaug

Comment 44

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cbc424d38040

Comment 45

[Ionuț Goldan [:igoldan]]

== Change summary for alert #29166 (as of Wed, 10 Mar 2021 07:55:25 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
1%	installer size		osx-shippable	nightly	86,259,015.17 -> 85,501,195.00
0.49%	installer size		osx-shippable	instrumented	114,648,786.08 -> 114,086,540.50

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29166

Comment 46

[Dzmitry Malyshau [:kvark]]

Attachment: Update wgpu and WebGPU IDL for the new copy views API

Updates wgpu, WebGPU IDL, in particular the ImageCopyXxx types and render pass attachments.
Adds explicit mapping of the GPUTextureFormat enum.

Comment 47

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b033d5d6e6d
Update wgpu and WebGPU IDL for the new copy views API r=webidl,jgilbert,smaug

Comment 48

[Atila Butkovits]

Backed out for causing bustages on WebGPUChild.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f02d7172dafc11f018ac917ba5bc4dc6dd72d79d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Um5wstbVSqm167a2hKj0dQ.0&revision=5b033d5d6e6d1dcab03863b56c14cfaaf06ce7b3&searchStr=linux%2Cx64%2Copt%2Cbuild-linux64%2Fopt%2Cb

Failure log: https://treeherder.mozilla.org/logviewer?job_id=335790516&repo=autoland&lineNumber=11250

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/306a4c2820ef
Update wgpu and WebGPU IDL for the new copy views API r=webidl,jgilbert,smaug

Comment 50

[Dzmitry Malyshau [:kvark]]

Annoying those C++ switches argh. Re-landing with a fix now.

Comment 51

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/306a4c2820ef

Comment 52

[Dzmitry Malyshau [:kvark]]

Attachment: Update BlendFactor API in WebGPU

This is another incremental update of wgpu and WebGPU APIs.
It increases stability and makes us run most of the Austin's samples (again).
Likely fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1704148

Comment 53

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da15c7605a0c
Update BlendFactor API in WebGPU r=webidl,jimb,smaug

Comment 54

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/da15c7605a0c

Comment 55

[Dzmitry Malyshau [:kvark]]

Attachment: Update WebGPU API to latest and wgpu-core to 0.9

This mostly gets us the latest WebIDL API of WebGPU. There is a few limits we are missing, and maybe some things I didn't notice.
But it gets us the new GPUCanvasContext, GPUSupportedLimits, and GPUVertexStepMode.

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cb3442efede
Update WebGPU API to latest and wgpu-core to 0.9 r=webidl,jgilbert,jimb,emilio

Comment 57

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3cb3442efede

Comment 58

[Noemi Erli[:noemi_erli]]

Backed out changeset 3cb3442efede (Bug 1622846) for causing Bug 1722702 CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=Android%2C7.0%2Cx86%2Copt%2CWebRender%2Cstandalone%2Cwebrender-wrench-android-release%2CB&tochange=3cb3442efede996a187e6dc00d055e8399254f46&fromchange=ffe5e3633446e353c31b738919b9cc5bcd8ca888&selectedTaskRun=BM4Ckqc-Rt-IKfI4vbv8EA.0

Log: https://treeherder.mozilla.org/logviewer?job_id=346577926&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/0e4800d5be4d74d5cf55e47c2bb763e48e1b62d3

Comment 59

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/0e4800d5be4d

Comment 60

[Dzmitry Malyshau [:kvark]]

Sad to see this backed out.

Comment 61

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e34f15d5e74d
Update WebGPU API to latest and wgpu-core to 0.9 r=webidl,jgilbert,jimb,emilio

Comment 62

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e34f15d5e74d

Comment 63

[Cristian Brindusan [:cbrindusan]]

Backed out changeset e34f15d5e74d (bug 1622846) for causing linux toolchain build bustages.
https://hg.mozilla.org/integration/autoland/rev/450a56178baf0337fc26e2b31571ae000dbc1a64

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=e34f15d5e74d023cd1f436e7bff8065af78a6364&selectedTaskRun=fbSyNS9kTk-16U2T4R1BxA.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=348775724&repo=autoland

Comment 64

[Atila Butkovits]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/09aa8d80251ab46ad827b027d5676143a3af41f1

Comment 65

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b55d42b538bd
Update WebGPU API to latest and wgpu-core to 0.9 r=webidl,jgilbert,jimb,emilio

Comment 66

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b55d42b538bd

Comment 67

[Dzmitry Malyshau [:kvark]]

Third time is the charm. Sorry about all the trouble!

Comment 68

[Dzmitry Malyshau [:kvark]]

Attachment: Bug 1622846 - Update wgpu to 28ba9d8 r=jimb

Update GPUTextureUsage bit names to match upstream.

Comment 69

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e97159bb402
Update wgpu to 5f6c067 r=jimb,emilio

Comment 70

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bp-hybrid bustages on WebGPUChild.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/1d73d6761ae21aae416ba4f3c04b79d504c9bbe1

• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=9e97159bb4024b342feb258979de913ed66b4cde&group_state=expanded

• failure log: https://treeherder.mozilla.org/logviewer?job_id=359605417&repo=autoland&lineNumber=23193

[task 2021-11-29T18:50:25.850Z] 18:50:25     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -o WebGPUChild.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/webgpu -I/builds/worker/workspace/obj-build/dom/webgpu -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wshadow-uncaptured-local -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Werror=implicit-int-conversion -fexperimental-new-pass-manager  -MD -MP -MF .deps/WebGPUChild.o.pp   /builds/worker/checkouts/gecko/dom/webgpu/ipc/WebGPUChild.cpp
[task 2021-11-29T18:50:25.850Z] 18:50:25    ERROR -  /builds/worker/checkouts/gecko/dom/webgpu/ipc/WebGPUChild.cpp:16:11: error: unused variable 'MAX_KNOWN_WARNINGS' [-Werror,-Wunused-const-variable]
[task 2021-11-29T18:50:25.850Z] 18:50:25     INFO -  const int MAX_KNOWN_WARNINGS = 10;
[task 2021-11-29T18:50:25.850Z] 18:50:25     INFO -            ^
[task 2021-11-29T18:50:25.851Z] 18:50:25     INFO -  1 error generated.
[task 2021-11-29T18:50:25.851Z] 18:50:25    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: WebGPUChild.o] Error 1
[task 2021-11-29T18:50:25.851Z] 18:50:25     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/webgpu'
[task 2021-11-29T18:50:25.851Z] 18:50:25     INFO -  gmake[4]: *** Waiting for unfinished jobs....

Comment 71

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b72d3ddcc2c2
Update wgpu to 28ba9d8 r=jimb,emilio

Comment 72

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b72d3ddcc2c2

Comment 73

[Dzmitry Malyshau [:kvark]]

Unfortunate backout because of a harmless warning. Re-landed now.

Comment 74

[Dzmitry Malyshau [:kvark]]

Attachment: WIP: Bug 1622846 - Support WebGPU adapter isFallbackAdapter

Comment 75

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/185bea049677
WIP: Bug 1622846 - Support WebGPU adapter isFallbackAdapter r=emilio

Comment 76

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/185bea049677

Comment 77

[Mathew Hodson]

This has the leave-open keyword but all the patches have landed. Can this be closed?

Comment 78

[Jim Blandy :jimb]

Yep. The specification has continued to evolve and Firefox needs work to catch up again, but that's not our focus at the moment, and we can open a fresh bug when we do start work on that.