1671800 - When two or more messages are selected/highlighted in the message pane, and you Ctrl-Click one of the selected/highlighted messages, the highlight does not go away until you move the mouse cursor off the message line.

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Mike Brazil]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. In the message pane, select two or more messages.
2. Ctrl-click one of the selected messages.
3. Move mouse cursor off message.

Actual results:

The highlight remains after Ctrl-clicking the message until you move the mouse cursor off the message line.

Expected results:

The highlight should disappear when you Ctrl-click and release the mouse button.

Comment 1

[Thomas D. (:thomas8)]

This worksfor me in default theme, light theme, and dark theme, on 78.3.3 (64-bit), Windows 10.
In dark theme difference isn't strong, but still visible.
Mike, we need a bit of background-color even for mouse-over to indicate which message you are pointing at, but it should be a lighter color than selection. Are you sure there is no color change when you ctrl-click to deselect without moving mouse out?
Can you provide a screenshot using PrintScreen button and attach here?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1671800-hover-treechilderen-HC.patch

This happens only on W7 Classic and high contrast themes. With this patch it behaves the same as the Windows Explorer: on W7 Classic no hover effect and on W10 HC themes only a border.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9182646 [details] [diff] [review]
1671800-hover-treechilderen-HC.patch

Review of attachment 9182646 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have the ability to test on Windows 7, but on Windows 10 this looks good.
Maybe worth creating a try-run for the reporter to test.

Comment 4

[Richard Marti (:Paenglab)]

Started a TB 78 try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a49a8d50110fa4d5988799bdfd440e81b2273bad

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1671800-hover-treechilderen-HC.patch

Added a missing space in the commit message.

Comment 6

[Richard Marti (:Paenglab)]

Mike, here is a ZIP build https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dJ6o_XyBRmOXkJjbIISD-g/runs/0/artifacts/public/build/target.zip or a installer build https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dJ6o_XyBRmOXkJjbIISD-g/runs/0/artifacts/public/build/install/sea/target.installer.exe of a TB 78 with the patch. Please can you try it?

Don't use your normal profile because going back to the official build could be blocked.

Comment 7

[Mike Brazil]

(In reply to Thomas D. (:thomas8) from comment #1)

This worksfor me in default theme, light theme, and dark theme, on 78.3.3 (64-bit), Windows 10.
In dark theme difference isn't strong, but still visible.
Mike, we need a bit of background-color even for mouse-over to indicate which message you are pointing at, but it should be a lighter color than selection. Are you sure there is no color change when you ctrl-click to deselect without moving mouse out?
Can you provide a screenshot using PrintScreen button and attach here?

I looked carefully when Ctrl-clicking, and there is no color change that I can discern. However, I do observe an almost, but not quite, invisible change to the lines above and below the selected message: they appear to become broken or dotted. I got a screenshot, but I'm new to this forum, and I'm not seeing a way to attach it.

Comment 8

[Mike Brazil]

(In reply to Richard Marti (:Paenglab) from comment #6)

Mike, here is a ZIP build https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dJ6o_XyBRmOXkJjbIISD-g/runs/0/artifacts/public/build/target.zip or a installer build https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dJ6o_XyBRmOXkJjbIISD-g/runs/0/artifacts/public/build/install/sea/target.installer.exe of a TB 78 with the patch. Please can you try it?

Don't use your normal profile because going back to the official build could be blocked.

Richard-

When I click on either link to download the patched file, I get this error (Using Waterfox 2020.08 (64-bit):

PR_CONNECT_RESET_ERROR

The page you are trying to view cannot be shown because the authenticity of the received data could not be verified.

Comment 9

[Richard Marti (:Paenglab)]

Hmm, both links are working here with FX.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/13b1d30a5f1a
Use only a border for hovered treechildrens on High Contrast/Classic themes. r=aleca

Comment 11

[Richard Marti (:Paenglab)]

Comment on attachment 9182710 [details] [diff] [review]
1671800-hover-treechilderen-HC.patch

[Approval Request Comment]
User impact if declined: Win7 Classic and Win10 HC theme users can't distinguish between selected and hovered treeitems.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, would only affect Classic and HC theme users.

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9182710 [details] [diff] [review]
1671800-hover-treechilderen-HC.patch

[Triage Comment]
Approved for next beta

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 83.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/dcc8f4b64d68

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9182710 [details] [diff] [review]
1671800-hover-treechilderen-HC.patch

[Triage Comment]
Approved for esr78

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/29984094a724

Comment 16

[WaltS48 [:walts48]]

Looks like I also missed this one for 83.0b2.

Looks fixed in the 78.4.1 release candidate test on Windows 10.

Comment 17

[Mike Brazil]

This is to confirm that the bug is fixed in 78.4.1 (64-bit). Thanks, everyone!