1672094 - Upgrade tsan builds to >= nightly-2020-09-19

Status: RESOLVED FIXED

(Testing :: Mochitest, defect, P3)

Description

[Cosmin Sabou [:CosminS]]

There were a few mochitest Linux 18.04 x64 tsan opt failures after Bug 1644624 landed here: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=609ac687f7e38023eae03bad472b1632d7d04768&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt&failure_classification_id=2

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#?job_id=319077132&repo=autoland
• https://treeherder.mozilla.org/logviewer.html#?job_id=319070213&repo=autoland

These were fixed by partially backing out Bug 1644624 here: https://hg.mozilla.org/integration/autoland/rev/fee83fc16940a1de26d34db3f1c62495438db83b

Comment 1

[Cosmin Sabou [:CosminS]]

This was backed out because bug 1644624 had to be backed out https://bugzilla.mozilla.org/show_bug.cgi?id=1644624#c17.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9a2598a10e2234fd475706330cd468acca9338ed

Comment 2

[Mike Hommey [:glandium]]

This starts happening somewhere between
rustc 1.47.0-nightly (7e6d6e5f5 2020-08-16)
and
rustc 1.47.0-nightly (792c645ca 2020-08-17)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1644624

Comment 4

[Mike Hommey [:glandium]]

Actually , 84 is unaffected because the part of bug 1644624 that causes these failures hasn't landed.

Comment 5

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #2)

This starts happening somewhere between
rustc 1.47.0-nightly (7e6d6e5f5 2020-08-16)
and
rustc 1.47.0-nightly (792c645ca 2020-08-17)

And the specific commit where it stated happening is 33c96b4d9782cf6364e47cb2c904e66b06c22bb4 (merge of https://github.com/rust-lang/rust/pull/74748) but it doesn't seem related, except for the fact that it might make rust code faster.

The failures, per https://treeherder.mozilla.org/#/jobs?repo=try&revision=45f8147af4c936bdc27903eed7a1336898ab7eac seem largely related to scrolling.

Comment 6

[Mike Hommey [:glandium]]

This appears to be fixed in more recent nightlies, which require bug 1667736

Comment 7

[Mike Hommey [:glandium]]

Ok, everything lines up:

• as per comment 5, the regression comes from https://github.com/rust-lang/rust/pull/74748
• that PR had a regression identified upstream: https://github.com/rust-lang/rust/issues/76803
• that issue was fixed with: https://github.com/rust-lang/rust/pull/76837
• bisecting when nightlies were fixed (since recent ones worked) pointed to https://github.com/rust-lang/rust/pull/76837

This means we'd need to upgrade to at least nightly-2020-09-19. Let's then go with the latest that was versioned 1.48.0-nightly.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1672094 - Upgrade tsan builds to the last rust nightly with version 1.48.0.

The first versions with 1.48 had a regression that was fixed later
during the 1.48.0 development phase. Use the last of those to have
something closer to a release, but still versioned 1.48.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b43d1c8c7639
Upgrade tsan builds to the last rust nightly with version 1.48.0. r=firefox-build-system-reviewers,dmajor

Comment 10

[Razvan Maries]

Backed out for build bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=XZ_qFLJEQKiP-JP9Wiprjw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=b43d1c8c7639169ef393aec68578a403c7865a08

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319658679&repo=autoland&lineNumber=14103

Backout: https://hg.mozilla.org/integration/autoland/rev/59f99782b6f765539848510f3e4fc01b11076bc4

Comment 11

[Mike Hommey [:glandium]]

Forgot that bug 1667736 needed to land first.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fb1100602b7
Upgrade tsan builds to the last rust nightly with version 1.48.0. r=firefox-build-system-reviewers,dmajor

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2fb1100602b7