Closed Bug 1672188 Opened 4 years ago Closed 4 years ago

ConstructPlanarYCbCrData should set color range

Categories

(Core :: Audio/Video, defect, P3)

defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: bryce, Assigned: bryce)

References

Details

Attachments

(1 file)

Bug 1493198 added code to handle a broader range of colours in the media and gfx pipelines (edit that bug added some multibit handling, bug 1543359 added the color range code). It looks like this code overlooks setting the color range value in ConstructPlanarYCbCrData.

Various color values set in this code don't seem to be used at this time (based on walking the code and debugging). However, it seems like a good idea to have the range set here to avoid problems down the road should

[0] https://searchfox.org/mozilla-central/rev/61728de8273c04fe2417c475fc0637e8b79210d7/dom/media/MediaData.cpp#259

Changing the depends on as bug 1543359 makes more sense since it added the color range code.

Depends on: 1543359
No longer depends on: 1493198
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97e1c2a7d98e
MediaData::ConstructPlanarYCbCrData should set color range. r=jya
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: