release1 indexer failure on oct 21
Categories
(Webtools :: Searchfox, task)
Tracking
(Not tracked)
People
(Reporter: kats, Assigned: kats)
References
(Regression)
Details
+ '[' -f android-armv7.mozsearch-rust-stdlib.zip ']'
+ unzip -qn android-armv7.mozsearch-rust-stdlib.zip -d objdir-android-armv7
+ mv -f objdir-android-armv7/rustlib/src/rust/src generated-android-armv7/__RUST_STDLIB__
mv: cannot stat 'objdir-android-armv7/rustlib/src/rust/src': No such file or directory
Not sure what's going on here, will investigate later today if nobody gets to it before me. (I'm on PTO today). I saw a commit go by yesterday about downloading xz fingers from rust upstream instead of gz, maybe that's related.
|
Assignee | |
Comment 1•4 years ago
|
||
I meant to type files instead of fingers but Fenix seems to have a bug where it relocates my cursor and won't let me edit it. What a disaster.
|
|
Assignee | |
Comment 2•4 years ago
•
|
||
Looks like the folder structure inside the stdlib tarball changed, perhaps a result of a rust version bump in m-c.
Old: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319115667&repo=mozilla-central&lineNumber=99886
New: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319233425&repo=mozilla-central&lineNumber=100788
Likely we'll have to change https://github.com/mozsearch/mozsearch-mozilla/blob/cf343fb2e4356f87f87084306beadb2f14f1afd4/shared/process-tc-artifacts.sh#L119 and maybe some surrounding code to deal with both old (for m-beta etc) and new (for m-c).
|
||
Comment 3•4 years ago
|
||
Please enjoy your PTO (or at least not work ;). I'll attempt to address this and maybe this is another good trial of post-commit review.
|
|
||
Comment 4•4 years ago
|
||
I only got as far as confirming :kats' old/new data was accurate today due to other primary concerns. I left the indexer stopped. I can try and revisit tomorrow afternoon but am releasing in case others want to address before that.
|
|
Assignee | |
Comment 6•4 years ago
|
||
AFAICT the folder structure is mostly the same except with the change of src -> library in the pathname. I triggered an indexer on my test channel with a potential fix.
|
|
||
Comment 7•4 years ago
|
||
It seems like the "lib" prefix from the directory name got removed too? "libproc_macro" became "proc_macro"?
|
|
Assignee | |
Comment 8•4 years ago
|
||
Yeah, although the corresponding analysis files have the same update. So that part doesn't seem to matter, AFAICT. My first attempt was incomplete and got caught by the check failures, so yay for those! Debugging that seems to indicate I need to add a new path normalization for the library/ path along with the src/ path. Trying that now.
|
|
Assignee | |
Comment 9•4 years ago
|
||
That worked. e.g. https://kats.searchfox.org/mozilla-central/source/__GENERATED__/__RUST_STDLIB__/alloc/src/collections/btree/map.rs#356 has semantic analysis data (this is the same file checked by the automated test).
|
|
Assignee | |
Comment 10•4 years ago
|
||
Fix deployed.
Description
•