1672461 - Pin package dependencies when installing Puppeteer in Mozilla CI

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P2)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

As pointed out in Bug 1671725, Puppeteer dependencies are not pinned.

To make the pup jobs reproducible, we should:

• pin the dependencies in package.json every time we sync from upstream Puppeteer
• generate and commit a package-lock.json every time we sync from upstream Puppeteer
• call npm ci instead of npm install in our mach command. Adding some verbose output here wouldn't hurt either.

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Adding DEBUG=mocha:cli:* to the environment yields useful info about what settings mocha is using.

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1672461 - [remote] Pin package dependencies when installing Puppeteer in Mozilla CI

Calling npm ci instead of npm install generates a reproducible
node_modules directory based on the entries in Puppeteer's package-lock.json

The most-recent Puppeteer sync (Bug 1670286) commits package-lock.json
to mozilla-central for the first time.

Depends on D97810

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80442bbcf255
[remote] Pin package dependencies when installing Puppeteer in Mozilla CI r=remote-protocol-reviewers,whimboo

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/80442bbcf255