BrowserParent::GetDocShellIsActive returns false on the foreground tab content when it's restored from seession
Categories
(GeckoView :: General, defect, P1)
Tracking
(Not tracked)
People
(Reporter: hiro, Assigned: agi)
Details
(Whiteboard: [geckoview:m84])
Though I wanted to provide a simple way to confirm this issue, but couldn't figure out the way. So to confirm this issue you need to build local Fenix (or GVE with bug 1500644).
- Build local Fenix with local m-c (because the current Fenix nightly hasn't been updated the latest m-c.)
- Open http://bokand.github.io/demo/urlbarsize.html on the Fenix
- Close the Fenix
- Launch the Fenix
- Make sure the site opened in comment 2 is opened in the restored session
- Try to scroll downwards
- See the right most bar's height
The bar height should be expanded when the dynamic toolbar is completely hidden, but actually it doesn't. That's because we notify the dynamic toolbar's height change only for the foreground tab by checking BrowserParent::GetDocShellIsActive(), but the function returns false even if it's the foreground one.
I believe this is a recent-ish regression.
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
I can't reproduce this anymore, I wonder if this was caused by Bug 1650118 somehow (which was backed out). Hiro can you still reproduce this?
|
|
Reporter | |
Comment 2•5 years ago
|
||
Oh yes, after updated my local tree, it works! I will try to narrow down which commit fixed it.
|
|
Reporter | |
Comment 3•5 years ago
|
||
This was actually fixed by the backed out change for bug 1650118, https://hg.mozilla.org/mozilla-central/rev/9d36bdde98891f77aa7eda36d41073653b44f2e9
|
|
Assignee | |
Comment 4•5 years ago
|
||
This is very likely a duplicate of Bug 1673316.
Description
•