1672667 - reply/followup to nntp messages is broken (compose window doesn't come up) if catchAll is enabled

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Magnus Melin [:mkmelin]]

Replying to an nntp message doesn't work on trunk. (E.g. news.mozilla.org mozilla.test)

In the console I get
The MsgHdrToMimeMessage callback threw an exception: TypeError: can't access property "parts", aPart is null
JavaScript error: resource:///modules/gloda/MimeMessage.jsm, line 134: TypeError: can't access property "parts", aPart is null

Not sure when it broke, but 2020-10-21 is at least broken.

Comment 1

[Magnus Melin [:mkmelin]]

Up to at least 2020-08-02 broken. I wonder if I have something odd in my profile. If it was broken since that long I'd think someone would have noticed.

Comment 2

[Magnus Melin [:mkmelin]]

It's due to catch all, and due to Gloda MimeMessage.jsm not being able to handle news messages - bug 545365

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1672667_nntp_catchall.patch

For the identities dialog it's a strange case since we don't know the server directly...

Comment 4

[Alessandro Castellani [:aleca]]

Mh, I can't seem to reproduce the error.
I'm subscribed to news.mozilla.org > mozilla.test, and when i click "Reply" to a message the compose window opens correctly.
It works also with Follow up and Reply all.

The last time I pulled was yesterday, my current revision is e17e6a8f62f090cb4e8475bf7a9c0268673b5ae8
I'm gonna pull and compile to see if I can reproduce the error with the latest trunk build.

Comment 5

[Magnus Melin [:mkmelin]]

You have to go into the account settings and for one identity set the catch all ("reply from this identity when delivery header match...")

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9183429 [details] [diff] [review]
bug1672667_nntp_catchall.patch

Review of attachment 9183429 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, thanks for the info.
This fixes the issue. r=aleca

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b03c2e644d52
don't use catchAll for nntp - not applicable and doesn't work. r=aleca

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9183429 [details] [diff] [review]
bug1672667_nntp_catchall.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1518025
User impact if declined: can't reply/followup to nntp messages if the catch-all pref is set for an identity
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Not very risky

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9183429 [details] [diff] [review]
bug1672667_nntp_catchall.patch

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 83.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/03d9b8199d96

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9183429 [details] [diff] [review]
bug1672667_nntp_catchall.patch

[Triage Comment]
Approved for esr78

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 78.4.1:
https://hg.mozilla.org/releases/comm-esr78/rev/c334dfead453