1672706 - Figure out how IPC replays are applied to the corresponding metrics

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Jan-Erik Rediger [:janerik]]

Right now FOG metrics in child processes store stuff in the IPC buffer.
The main process IPC receiver deserializes it and then ... displays it and that's it.

We need to figure out how to apply the recordings to the existing metrics.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Stop unimplemented metric types from breaking the build. r?chutten!

Not all types have corresponding C++ implementations (for the C++ and JS API) yet.
To avoid too much work right now we skip auto-generating any code for
these types for now until we do have them.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Turn the metric ID into an opaque type around the integer representation. r?chutten!

Depends on D95006

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Store metric ID in counter & replay counter metrics from IPC. r?chutten!

This now ensures we can:

1. Look up a metric by its (numeric) ID again (which is cheaper than
   carrying around strings.
2. Replay counter increments coming in from the IPC buffer

Depends on D95007

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Take the metric ID for a boolean metric. r?chutten!

This moves the tests to allow for test-only functionality.
This will allow to more easily test IPC behavior in pure Rust.

Depends on D95008

Comment 5

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Take the metric ID for a datetime metric. r?chutten!

Depends on D95009

Comment 6

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Take the metric ID for a string metric. r?chutten!

Depends on D95010

Comment 7

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Take the metric ID for a timespan metric. r?chutten!

Depends on D95011

Comment 8

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Store the metric ID in a memory distribution metric. r?chutten!

Depends on D95012

Comment 9

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Take the metric ID for a timing distribution metric. r?chutten!

Depends on D95013

Comment 10

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Store the metric ID in a string list metric. r?chutten!

Depends on D95014

Comment 11

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Wait for Glean to initialize before submitting a ping in the test. r?chutten!

Depends on D95015

Comment 12

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Store the metric ID in an event metric. r?chutten!

Depends on D95016

Comment 13

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Receive and pass on the metric ID for labeled metrics. r?chutten!

Depends on D95017

Comment 14

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Store the metric ID in a timing distribution metric. r?chutten!

Depends on D95013

Comment 15

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Take the metric ID for a UUID metric r?chutten!

Depends on D95017

Comment 16

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1672706 - Document when and how metric types need to store the metric ID. r?chutten!

Depends on D95510

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c6cd4b1cf44
Stop unimplemented metric types from breaking the build. r=chutten
https://hg.mozilla.org/integration/autoland/rev/02261b74f887
Turn the metric ID into an opaque type around the integer representation. r=chutten
https://hg.mozilla.org/integration/autoland/rev/f66355a21630
Store metric ID in counter & replay counter metrics from IPC. r=chutten
https://hg.mozilla.org/integration/autoland/rev/025d1f7457ec
Take the metric ID for a boolean metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/8f4d4480020b
Take the metric ID for a datetime metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/546625e61b06
Take the metric ID for a string metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/a7a415438ca7
Take the metric ID for a timespan metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/c5514bf0a84c
Store the metric ID in a memory distribution metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/48a6bef980ae
Store the metric ID in a timing distribution metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/cbb24d0d69af
Store the metric ID in a string list metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/2d89bad6e074
Wait for Glean to initialize before submitting a ping in the test. r=chutten
https://hg.mozilla.org/integration/autoland/rev/01a91886058b
Store the metric ID in an event metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/37c0ff672a45
Take the metric ID for a UUID metric r=chutten
https://hg.mozilla.org/integration/autoland/rev/bb84538de3fd
Receive and pass on the metric ID for labeled metrics. r=chutten
https://hg.mozilla.org/integration/autoland/rev/829ee953051e
Document when and how metric types need to store the metric ID. r=chutten

Comment 18

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4c6cd4b1cf44
https://hg.mozilla.org/mozilla-central/rev/02261b74f887
https://hg.mozilla.org/mozilla-central/rev/f66355a21630
https://hg.mozilla.org/mozilla-central/rev/025d1f7457ec
https://hg.mozilla.org/mozilla-central/rev/8f4d4480020b
https://hg.mozilla.org/mozilla-central/rev/546625e61b06
https://hg.mozilla.org/mozilla-central/rev/a7a415438ca7
https://hg.mozilla.org/mozilla-central/rev/c5514bf0a84c
https://hg.mozilla.org/mozilla-central/rev/48a6bef980ae
https://hg.mozilla.org/mozilla-central/rev/cbb24d0d69af
https://hg.mozilla.org/mozilla-central/rev/2d89bad6e074
https://hg.mozilla.org/mozilla-central/rev/01a91886058b
https://hg.mozilla.org/mozilla-central/rev/37c0ff672a45
https://hg.mozilla.org/mozilla-central/rev/bb84538de3fd
https://hg.mozilla.org/mozilla-central/rev/829ee953051e