Open Bug 1672748 Opened 4 years ago Updated 4 years ago

AboutHomeStartupCacheChild should alert the parent if the worker was terminated while generating the cache

Categories

(Firefox :: New Tab Page, task, P3)

Product:
Firefox
Component:
New Tab Page
Type:
task

Tracking

()

People

(Reporter: mconley, Unassigned)

References

(Blocks 1 open bug)

Details

In bug 1647757, I made it so that the cache worker can be terminated during memory-pressure. This is good.

However, I may have opened us up for a problem here. If the worker terminates while it's still in the process of generating the cache document, we'll reject here:

https://searchfox.org/mozilla-central/rev/25d5a4443a7e13cfa58eff38f1faa5e69f0b170f/browser/components/newtab/AboutNewTabService.jsm#237-241

which will be caught by that finally, and then I believe page and script will be undefined. Then we'll end up constructing two empty streams to send up to the parent as cache data.

Instead, I think we should tell the parent that constructing the cache failed, and that we should try again later.

Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.