1672786 - Delimiters inside <input type=date> should not be selectable (or the whole text should be selectable)

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

1. Open https://mdn.mozillademos.org/en-US/docs/Web/HTML/Element/input/date$samples/Value?revision=1642094
2. Try selecting the text inside the element

The delimiters (/ for me) are unexpectedly selectable, while actual date numbers are not. It should be consistent.

Since the element has its own Selection area (it can't be selected together with its siblings), I guess blocking selection for now is the way to go.

See also bug 1669996 as this also causes leaking internal nodes. (No security issue as the resulting object is sealed as [Restricted].)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

How are you selecting them? I can't select the delimiters.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: node selection

I drag from bottom-right to the top-left and it gets selected:

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

BTW, I see it's already using shadow DOM: https://searchfox.org/mozilla-central/rev/25d5a4443a7e13cfa58eff38f1faa5e69f0b170f/toolkit/content/widgets/datetimebox.js

Weird that it still can't be selected with nearby nodes. Do we have a bug for this? (I can also see same behavior in other shadow DOM demos: https://radogado.github.io/shadow-dom-demo/)

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: bug1672786-date-selection.html

Easier repro. Try selecting from foo to bar or in reverse direction. The text selection suddenly disappears and is replaced with selection inside <input>, which is probably bug 1455893.

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1672786 - Disable selection within <input type=date> r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/836fa52c6800
Disable selection within <input type=date> r=emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26278 for changes under testing/web-platform/tests

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/836fa52c6800

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot