1455893 - Cannot select elements across shadow boundaries.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

STR:

 * Go to https://wpt.fyi/css/cssom/interfaces.html
 * Try selecting content from the warning message that says:

> Data below are intended for web platform implementers and do not contain useful metrics for evaluation or comparison of web platform features. Also note that tested Edge and Safari are not pre-release versions (#109, #110).

   and moving it into the results table.

Expected:

 * I can select text across shadow DOM boundaries.

Actual:

 * The selection is chomped to the table contents inside the Shadow Root.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

This is a spec issue too. As far as I know, Gecko works like Webkit, since that is per current spec.

Comment 2

[Sean Feng [:sefeng]]

I am going to spend some time in the shadow dom cross boundary selecton proposal and see what we can do.

Comment 3

[Sean Feng [:sefeng]]

Attachment: shadow-dom-selection.html

Looks like STR is outdated, so I attached a new testcase.

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

Is this still being worked on? Otherwise consider unassigning it.

Comment 6

[Sean Feng [:sefeng]]

Yeah, I am working on this

Comment 7

[Mirko Brodesser (:mbrodesser-Igalia)]

Any gut feeling yet how complex fixing this is? Any context here is appreciated.

Comment 8

[Sean Feng [:sefeng]]

Implementing the spec to return the ranges that have the correct start and end nodes is easy, though making the actual selection work (ie. the blue selection background) is hard.

Mostly due the selection code has the assumption that no shadow DOM is involved. For example ContentIterator doesn't iterate elements in shadow DOM, range gets confused for its common ancestor. Lots of assertions had the same assumption so it's hard to fix them. Slotted contents makes the entire thing more complicated.

Plus the same code has been used not only by selection but also editor stuff, which adds another level of complexity.

So far I've implemented the spec and made the visual selection works for some fairly complex shadow trees. I am fixing test failures related to editor and slotted contents. Fixed lots of them already, but still have a decent number of failures to go.

Hope this provides some context :)

Comment 9

[Mirko Brodesser (:mbrodesser-Igalia)]

Hope this provides some context :)

It did, thanks.

Btw., be aware that the clipboard-code might need refinement too.

Comment 10

[Sean Feng [:sefeng]]

Attachment: Bug 1455893 - Fix a bug where incorrect frame is used for shadow-crossing selection r=smaug

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e37dd09ed484
Fix a bug where incorrect frame is used for shadow-crossing selection r=smaug

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e37dd09ed484