167282 - remove "nsILocalFile file" and "nsIFileURL fileURL" from nsIFilePicker, just use "nsISimpleEnumerator files"

Status: NEW

(Core :: XUL, defect)

Description

[(not reading, please use [e-mail] instead)]

>Why we need both mFile and mFiles? For backward compatibility?

see http://bugzilla.mozilla.org/show_bug.cgi?id=121122#c20

"I'll also log a cleanup bug on this:

readonly attribute nsILocalFile file;
readonly attribute nsISimpleEnumerator files;"

Comment 1

[(not reading, please use [e-mail] instead)]

  
readonly attribute nsILocalFile file;
readonly attribute nsIFileURL fileURL;
readonly attribute nsISimpleEnumerator files;

All weed need is:

nsISimpleEnumerator files;

if consumers need the nsILocalFile, they can QI.

if they need nsIFileURL, they can do:

+    var ioService = Components.classes["@mozilla.org/network/io-service;1"]
+    ioService = ioService.getService(Components.interfaces.nsIIOService);
+    var fileURL = ioService.newFileURI(file);
+    fileURL = fileURL.QueryInterface(Components.interfaces.nsIFileURL);

if they just need the spec:

+    var ioService = Components.classes["@mozilla.org/network/io-service;1"]
+    ioService = ioService.getService(Components.interfaces.nsIIOService);
+    var urlSpec = ioService.getURLSpecFromFile(file);

perhaps having a nsILocalFile firstFile would make sense, as a helper method.

all this comes about because of #121122 and modeOpenMultiple

Comment 2

[(not reading, please use [e-mail] instead)]

I'll probably take this from pavlov.

pav, any objections?

Comment 3

[Steve Dagley]

Pav object to someone taking one of his bugs?  It's never happen.  Taking to
start the process of cleaning up nsIFilePicker

Comment 4

[Alec Flett]

see also bug 102013, about removing just the fileURL part. 
I'd love to see this happen!

Comment 5

[Steve Dagley]

Since I don't report into Internet Technologies anymore this bug needs a new
owner -> saari

Being somewhat overeager to rid my system of CFM builds I managed to nuke the
tree that had the work on this.  All that's left is an old version of
nsFilePicker.cpp which had been overhauled for style consistency and to have the
pre-Carbon code partitioned in a cleaner manner.  If whoever ends up with this
bug wants a copy of that let me know.

Comment 6

[saari (gone)]

->ccarlen (guessing ownership)

Comment 7

[Conrad Carlen (not reading bugmail)]

Taking for 1.4a. Let me know if we need it before then.

Comment 8

[Conrad Carlen (not reading bugmail)]

-> 1.4b, along with related bug.