Disabled range controls don't look right with the basic theme
Categories
(Core :: Widget, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(3 files)
Spec: https://mozilla.invisionapp.com/share/5CX2MH6EHFB#/screens/415584863_Form_Widgets
Testcase: http://stephenhorlander.com/form-controls.html
(with widget.disable-native-theme-for-content
set to true)
On disabled range controls, the range thumb currently reacts to hover and mousedown. The thumb also isn't properly transparent. And making the thumb transparent would make the track pieces behind it visible.
Assignee | ||
Comment 1•4 years ago
|
||
This feels a bit nicer but the difference isn't visible to the user.
But it demonstrates how we can fix progress bars.
Assignee | ||
Comment 2•4 years ago
|
||
This makes the thumb respect the disabled, active and hover state of the range
control.
Depends on D94699
Assignee | ||
Comment 3•4 years ago
|
||
This makes the disabled state look good because the track pieces are no longer
visible behind the partially-transparent disabled thumb.
Depends on D94700
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/c586fc967b88 Draw range progress and track pieces with the same rounded rect but different rectangular clips. r=spohl https://hg.mozilla.org/integration/autoland/rev/783918e69c25 Draw thumb as part of the range control. r=spohl https://hg.mozilla.org/integration/autoland/rev/8eeb925b28d5 Clip out the range thumb when drawing the progress and track pieces. r=spohl
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c586fc967b88
https://hg.mozilla.org/mozilla-central/rev/783918e69c25
https://hg.mozilla.org/mozilla-central/rev/8eeb925b28d5
Description
•