Closed
Bug 1673341
Opened 4 years ago
Closed 4 years ago
Permanent menubar visibility toggling doesn't work (menu bar is hidden again)
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox81 | --- | unaffected |
| firefox82 | --- | unaffected |
| firefox83 | --- | unaffected |
| firefox84 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
STR:
- open Firefox
- right click navbar
- click "menu bar" to unhide the menubar
- open a new window
ER:
menu bar is visible
AR:
menu bar is hidden
|
Assignee | |
Comment 1•4 years ago
|
||
Root cause here is that we persist the attribute before we toggle it; so we end up persisting the "autohide" value "true" before toggling it to "false".
We should add tests for this...
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: in-testsuite?
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
Severity: -- → S2
status-firefox81:
--- → unaffected
status-firefox82:
--- → unaffected
status-firefox83:
--- → unaffected
status-firefox-esr78:
--- → unaffected
Priority: -- → P1
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3f3d77fb0f37
fix menu bar toggling to persist the correct state, r=jaws
|
|
Assignee | |
Updated•4 years ago
|
Flags: in-testsuite? → in-testsuite+
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•