1673403 - Show the bookmarks toolbar in customize mode when it is enabled for the new tab page

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dave Townsend [:mossop] (PTO until Aug 21st)]

If you have your bookmarks toolbar set to only show on the new tab page and then go to customize your toolbars you can't see it to be able to modify it. "Only on New Tab Page" should also cause the toolbar to be visible in customize mode.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1673403 - Show the Bookmarks Toolbar in customize mode as long as it's not set to Never show.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e52abe08f115
Show the Bookmarks Toolbar in customize mode as long as it's not set to Never show. r=Gijs

Comment 4

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=AyLmXfLeSpGjjJZEc6pLAw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=e52abe08f115bb2a941c529ae89bb3eb0f5794f4&searchStr=bc&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer?job_id=320653738&repo=autoland&lineNumber=9136
https://treeherder.mozilla.org/logviewer?job_id=320651828&repo=autoland&lineNumber=16165
https://treeherder.mozilla.org/logviewer?job_id=320652637&repo=autoland&lineNumber=41196
https://treeherder.mozilla.org/logviewer?job_id=320652621&repo=autoland&lineNumber=59167

Backout: https://treeherder.mozilla.org/jobs?repo=autoland&revision=b03957242e70e0803fc99db6016c372b42b91aac

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79fdd548ff26
Show the Bookmarks Toolbar in customize mode as long as it's not set to Never show. r=Gijs

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/79fdd548ff26

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #27641 (as of Fri, 13 Nov 2020 19:44:26 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
2%	pdfpaint		linux64-shippable-qr	e10s stylo webrender-sw	350.28 -> 343.21
1%	pdfpaint		linux64-shippable-qr	e10s stylo webrender-sw	345.34 -> 343.21

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27641

Comment 8

[Daniel Cicas [:dcicas], Release QA]

Verified on Fx 84.0b4 on Windows 10 x64, Ubuntu 18.04 and macOS 10.15