1673440 - Report actual illegal character

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Tom S. (please needinfo tschuster)]

Right now we just report "illegal character" in the tokenizer. We can improve this include the actual unicode code point. This also gives you an opportunity of some messing with you by including ZERO WIDTH SPACE.

> eval("var x =\u{200B}")
SyntaxError: illegal character U+200B
> eval("var x = @")
SyntaxError: illegal character U+0040

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1673440 - Report actual illegal character when parsing JS. r?arai

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1673440 - Update devtools evaluationResult test after illegal character error message change

Depends on D94767

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a0e794b51bf
Report actual illegal character when parsing JS. r=arai
https://hg.mozilla.org/integration/autoland/rev/c4448be58fcb
Update devtools evaluationResult test after illegal character error message change r=nchevobbe

Comment 4

[Razvan Maries]

Backed out for SM Bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=c4448be58fcb409e1aac608238cb5d38a4d29509&searchStr=spider%2Cmonkey

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319868093&repo=autoland&lineNumber=7956

Backout: https://hg.mozilla.org/integration/autoland/rev/ab66bd46c2d6874336d5fad4faceaa9b9448ff5f

Comment 5

[Tom S. (please needinfo tschuster)]

I didn't update a jsapi-test that checked the illegal character message.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e14ca19d32ba
Report actual illegal character when parsing JS. r=arai
https://hg.mozilla.org/integration/autoland/rev/5362c99dfe66
Update devtools evaluationResult test after illegal character error message change r=nchevobbe

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e14ca19d32ba
https://hg.mozilla.org/mozilla-central/rev/5362c99dfe66