Report actual illegal character
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Right now we just report "illegal character" in the tokenizer. We can improve this include the actual unicode code point. This also gives you an opportunity of some messing with you by including ZERO WIDTH SPACE.
> eval("var x =\u{200B}")
SyntaxError: illegal character U+200B
> eval("var x = @")
SyntaxError: illegal character U+0040
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D94767
|
||
Updated•4 years ago
|
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5a0e794b51bf Report actual illegal character when parsing JS. r=arai https://hg.mozilla.org/integration/autoland/rev/c4448be58fcb Update devtools evaluationResult test after illegal character error message change r=nchevobbe
|
||
Comment 4•4 years ago
|
||
Backed out for SM Bustages.
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=c4448be58fcb409e1aac608238cb5d38a4d29509&searchStr=spider%2Cmonkey
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319868093&repo=autoland&lineNumber=7956
Backout: https://hg.mozilla.org/integration/autoland/rev/ab66bd46c2d6874336d5fad4faceaa9b9448ff5f
|
|
Assignee | |
Comment 5•4 years ago
|
||
I didn't update a jsapi-test that checked the illegal character message.
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e14ca19d32ba Report actual illegal character when parsing JS. r=arai https://hg.mozilla.org/integration/autoland/rev/5362c99dfe66 Update devtools evaluationResult test after illegal character error message change r=nchevobbe
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e14ca19d32ba
https://hg.mozilla.org/mozilla-central/rev/5362c99dfe66
Description
•