1676125 - 6.86 - 7.78% pinterest Similarity / pinterest Similarity2D (linux64-shippable-qr) regression on push c4448be58fcb409e1aac608238cb5d38a4d29509 (Tue October 27 2020)

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a browsertime performance regression from push c4448be58fcb409e1aac608238cb5d38a4d29509. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
8%	pinterest	Similarity	linux64-shippable-qr	cold webrender	0.95 -> 0.88
7%	pinterest	Similarity2D	linux64-shippable-qr	cold webrender	0.99 -> 0.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1673440

Comment 2

[Tom S. (please needinfo tschuster)]

What is this about? I don't see how a changed error messages could cause a regression. And you seem to have closed this bug anway?

Comment 3

[Alexandru Ionescu (needinfo me) [:alexandrui]]

I closed it because it was fixed in Bug 1672238. I believe you, but the graph is pretty clear about. I couldn't tell why your patch caused that as I not that familiar with the code in it.

Comment 4

[Tom S. (please needinfo tschuster)]

Must be some kind of fluke. The "fix" has nothing do with my patch either. I am going to ignore this.