1673835 - Duplicated day enumeration displayed in month view (german), e.g., friday (29.) and saturday (30.) are tagged as 29th.

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[benedikt.pfuelb]

Attachment: thunderbird_bug.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.111 Safari/537.36

Steps to reproduce:

1. open the calendar tab (week start is on monday)
2. select "year back" in short overview until 1989 is reached (october is already selected)
3. select Sunday 1st of september in short overview

Information for Bug report (german, shortened):

Allgemeine Informationen

Name: Thunderbird
Version: 78.4.0
Build-ID: 20201019003438
Distributions-ID:

Update-Kanal: release
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0
Betriebssystem: Windows_NT 10.0

Starter-Prozess: Aktiviert
Fenster mit mehreren Prozessen: 0/0
          deaktiviert
Externe Prozesse: 0
Unternehmensrichtlinien: Inaktiv
Google-Location-Service-Schlüssel: Fehlt
Google-Safebrowsing-Schlüssel: Fehlt
Mozilla-Location-Service-Schlüssel: Fehlt
Abgesicherter Modus: false

Internationalisierung & Lokalisierung

  Anwendungseinstellungen
  Angeforderte Sprachen: ["de"]
  Verfügbare Sprachen: ["de","en-US"]
  Anwendungssprachen: ["de","en-US"]
  Region-Einstellungen: ["de-DE"]
  Standardsprache: "de"

  Betriebssystem
  Sprachen des Betriebssystems: ["de-DE"]
  Region-Einstellungen: ["de-DE"]

Actual results:

In month view (october 1989 selected) the friday 29.9.1989 and saturday 30.9.1989 are maked with "29." (Fr) and "29. Sept." (Sa) and also wrong the sunday 1.10.1989 is marke with 30. Sept.

Expected results:

In month view (october 1989 selected) the saturday 30.9.1989 should be maked with "30" and the sunday should be "1".

Comment 1

[:Gijs (he/him)]

Doesn't look like this was intended to be marked security sensitive.

Comment 2

[Martin Schröder [:mschroeder]]

This bug report reminds me of bug 1584222.

Comment 3

[Geoff Lankow (:darktrojan)]

That's very weird. I can see this bug up until 2006. I wonder what happened in 2006.

Comment 4

[Ian Eales]

In 2006, Daylight Saving or Summer Time changes were made for 2007.
I recall that it caused problems in the global vessel tracking application I was developing.

Comment 6

[Geoff Lankow (:darktrojan)]

For various reasons we don't keep time zone information earlier than 2018.

Comment 10

[Martin Schröder [:mschroeder]]

Attachment: Bug 1673835 - Pass a date-only calDateTime as such when converting to a JS Date for formatting. r=darktrojan

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58da46162bcd
Pass a date-only calDateTime as such when converting to a JS Date for formatting. r=darktrojan

Comment 12

[Magnus Melin [:mkmelin]]

Please request uplifts for 93 beta and 91.

Comment 13

[Martin Schröder [:mschroeder]]

Comment on attachment 9239519 [details]
Bug 1673835 - Pass a date-only calDateTime as such when converting to a JS Date for formatting. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Shows wrong/duplicated dates or is missing dates in calendar month/week day headers
Testing completed (on c-c, etc.): -
Risk to taking this patch (and alternatives if risky): The changes in date formatting could lead to regressions in other usages which are not covered by tests.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9239519 [details]
Bug 1673835 - Pass a date-only calDateTime as such when converting to a JS Date for formatting. r=darktrojan

[Triage Comment]
Approved for beta

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 93.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/586e52759abc

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9239519 [details]
Bug 1673835 - Pass a date-only calDateTime as such when converting to a JS Date for formatting. r=darktrojan

[Triage Comment]
Approved for esr91

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 91.2.0:
https://hg.mozilla.org/releases/comm-esr91/rev/2bbd614dedaf

Comment 19

[WaltS48 [:walts48]]

Verified testing the 91.2 en-US release candidate on Windows 10.