1673902 - [openpgp.configure] Check for mkdtemp always fails

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

The check in openpgp.configure for mkdtemp never succeeds because the checking function (check_symbol_exists) does not properly handle a list of potential header files.
The function itself is used in the RNP test suite (which is not currently run in CI). On Linux and OpenBSD it's found in stdlib.h, while on macOS it's in unistd.h.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1673902 - Check multiple header files for symbols in openpgp.configure. r?justdave

The header parameter to check_symbol_exists() could be a list of strings or a single
string. The only place where a list is sent is for mkdtemp which could be in
stdlib.h or unistd.h depending on the operating system.
Currently, the check for mkdtemp always fails as the generated C code is invalid.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ba9f25c24b7
Check multiple header files for symbols in openpgp.configure. r=justdave

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9184877 [details]
Bug 1673902 - Check multiple header files for symbols in openpgp.configure. r?justdave

[Approval Request Comment]
The effect of this change is that the compiler will use mkdtemp when compiling librnp. It's a "safer" variant of the same function and should work as expected on platforms that support it. (Windows being the outlier that does not support mkdtemp).

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9184877 [details]
Bug 1673902 - Check multiple header files for symbols in openpgp.configure. r?justdave

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 83.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/66553a0e413b

Comment 6

[Rob Lemley [:rjl]]

This patch is a requirement for the RNP October 2020 update (bug 1675516).
That RNP update adds mkstemp as a required function and is detected in one of two header files, the same as mkdtemp.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9184877 [details]
Bug 1673902 - Check multiple header files for symbols in openpgp.configure. r?justdave

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/aded76617aa9