1673959 - Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news|

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ian Neal]

When bug 1425962 and bug 1466705 were done no equivalent strings were added for SeaMonkey. This means wherever bug 1425962 and bug 1466705 have/get landed we would break.

Comment 1

[Ian Neal]

Attachment: Additions for bug 1425962

[Approval Request Comment]
Regression caused by (bug #): 1425962
User impact if declined: Broken subscribe dialog when bug 1425962 is applied
Testing completed (on m-c, etc.): 2.53.x
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 2 removals, 2 additions

Comment 2

[Ian Neal]

Attachment: Additions for bug 1466705

[Approval Request Comment]
Regression caused by (bug #): 1466705
User impact if declined: Broken subscribe dialog when bug 1466705 is applied
Testing completed (on m-c, etc.): 2.53.x
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 2 additions

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9184385 [details] [diff] [review]
Additions for bug 1425962

LGTM

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9184386 [details] [diff] [review]
Additions for bug 1466705

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c8813a3ae2c8
Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news| - bug 1425962 part. r=frg
https://hg.mozilla.org/comm-central/rev/cc1b4c09df39
Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news| - bug 1466705 part. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9184385 [details] [diff] [review]
Additions for bug 1425962

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/21dc88f2a172c1993bf5dc099d946e5631b6e25f
Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news| - bug 1425962 part. r=frg a=frg

Comment 7

[Frank-Rainer Grahl (:frg)]

1673959

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9184386 [details] [diff] [review]
Additions for bug 1466705

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/13d1aa3c4aaf955473dd6a6b445d0d2cee16fa9e
Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news| - bug 1466705 part. r=frg a=frg