1674138 - Introduce pref so we can ensure "browser.partnerlink.attributionURL" is used

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Comment 1

[Dale Harvey (:daleharvey)]

Hey Mike

Doing the patch for this, any version of this patch[1] seems like it leads to confusing situations if remoteSettings = false and useAttributeLink = true. Do you think we should either set or target remoteSettings = true as part of the experiment?

[1] - https://gist.github.com/daleharvey/d1d5a4f0c85b449c443faa39202e9709

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1674138 - Add pref to ensure attributionUrl is used.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdb3b6e6e299
Add pref to ensure attributionUrl is used. r=mikedeboer

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bdb3b6e6e299

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 9185569 [details]
Bug 1674138 - Add pref to ensure attributionUrl is used.

Beta/Release Uplift Approval Request

• User impact if declined: Not user facing, this renames a pref that is to be use by upcoming experiments that we were planning to launch in fx83
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Its a pref rename that will only be used in experiments
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9185569 [details]
Bug 1674138 - Add pref to ensure attributionUrl is used.

Approved for the beta branch before the merge, thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Landed for 83.0b10.
https://hg.mozilla.org/releases/mozilla-beta/rev/3411bf7d9c23