1676101 - Remove browser.partnerlink.useAttributionURL pref

Status: RESOLVED FIXED

(Firefox :: Top Sites, task, P1)

Description

[Dão Gottwald [:dao]]

From what I can tell, we can always use browser.partnerlink.attributionURL at this point. Short of that, I think it would be preferable to keep browser.topsites.useRemoteSetting as an implied way to use browser.partnerlink.attributionURL, to avoid the foot-gun of not having set browser.partnerlink.useAttributionURL which I suspect people involved with the remote setting experiment aren't aware of yet (at least I was completely unaware until I stumbled upon bug 1674138).

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1676101 - Remove browser.partnerlink.useAttributionURL pref. r=mikedeboer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/722522a451a9
Remove browser.partnerlink.useAttributionURL pref. r=mikedeboer

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 9186592 [details]
Bug 1676101 - Remove browser.partnerlink.useAttributionURL pref. r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: Potential confusion for people involved with testing and setting up the top sites experiment for 83 due to the late addition of the browser.partnerlink.useAttributionURL pref
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed:

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/722522a451a9

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9186592 [details]
Bug 1676101 - Remove browser.partnerlink.useAttributionURL pref. r=mikedeboer

@mikedeboer is telling me that by now all stakeholders are aware of the pref so we don't need to uplift this.