1674199 - Don't show the bookmarks toolbar when New Tab page is disabled

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Currently when a user disables the New Tab page via about:preferences when setting New Tab to "Blank page", we will show the Bookmarks Toolbar on top-level about:blank pages.

This might not be what users actually want if they want a blank page for new tabs, and it opens us up to a number of bugs that occur since about:blank is used for many other cases than just a blank new tab page.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1674199 - Remove the special case of showing the bookmarks toolbar on about:blank if NTP is disabled.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Per discussion we've decided not to go this route anymore.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

We are going to re-open this bug due to the number of issues related to showing the New Tab Page on about:blank and the limited time we have for 84.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/878452338e51
Remove the special case of showing the bookmarks toolbar on about:blank if NTP is disabled. r=Gijs

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/878452338e51

Comment 6

[Daniel Cicas [:dcicas], Release QA]

Hello,

Verified in Fx beta 84.0b4 on Windows 10x64, Ubuntu 18.04 and macOS 10.15.