Closed Bug 1674212 Opened 4 years ago Closed 3 years ago

Add override for date time connector pattern

Categories

(Core :: Internationalization, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

Bug 1426907 added pref overrides for date and time, but it is still not possible to get ISO 8601 formatted dates (bug 1426907 comment 183). Adding an override for the connector pattern would make it possible for people to get rid of the pesky , connecting the date and time if they so desire.

This adds an override pref for the connector pattern used when combining dates
and times. It also fixes a test which was relying upon a hard-coded connector
pattern.

Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f77aed0b041a
Add override pref for date time connector pattern; r=zbraniecki
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Why did you chose intl.date_time.pattern_override.date_time_short as the pref name? Isn't it the "date time connector"? What's the relation to "short" as in intl.date_time.pattern_override.date_short and intl.date_time.pattern_override.time_short. Is the connector only used when "short date" and "short time" are connected?

Flags: needinfo?(dminor)

I don't remember. Looking at the code again, I think "date_time_connector" or "connector_pattern" would have made more sense. If you think it is important enough, please file a new bug to have this changed.

Flags: needinfo?(dminor)
Blocks: 1706318

Thanks, I filed bug 1706318 giving a bit of background. "Important enough" is in the eye of the beholder, the naming is a bit surprising, so before it gets documented (see bug 1426907 comment #164), it might as well be improved.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: