Rename short connector pattern override preference to intl.date_time.pattern_override.connector_short
Categories
(Core :: Internationalization, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: jose, Assigned: dminor)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.72 Safari/537.36
Steps to reproduce:
Follow-up to bug 1674212:
Bug 1674212 introduced a preference intl.date_time.pattern_override.date_time_short. As per bug 1674212 comment #5, intl.date_time.pattern_override.date_time_connector would be a better name.
Looks like a few people from Thunderbird are interested in this functionality, see also bug 1426907 where the initial intl.date_time.pattern_override.* were introduced. So now is the time rename the preference before both bugs get shipped in ESR 91 coming up in a few months.
Actual results:
Sub-optimal preference name.
Expected results:
Better preference name.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
What do you think about override.date_time_connector.short
? From the comments here [1] we'd like to keep short
in the name.
[1] https://phabricator.services.mozilla.com/D112815#3669689
Reporter | ||
Comment 3•3 years ago
|
||
Thanks for consulting. In bug 1426907 you added
intl.date_time.pattern_override.xxxx_yyyy
where xxxx
is date
or time
and yyyy
is short
, medium
, long
or full
. Note that it is, for example, _short
not .short
, so intl.date_time.pattern_override.date_time_connector.short
doesn't appear to fit the scheme.
Had you implemented intl.date_time.pattern_override.xxxx.yyyy
for example intl.date_time.pattern_override.time.short
, then intl.date_time.pattern_override.connector.short
would be the obvious choice now.
Consequently I suggest intl.date_time.pattern_override.connector_short
, that is adding connector
to the xxxx
domain. Let's hope that no one asks for the long
version. I looked at the references in the Phab comments and for English the long connector seems to be {1} at {0}
, so such-and-such a date at this time, but as you discussed, that isn't used.
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a51b1ea8975 Rename connector pattern override preference; r=zbraniecki
Reporter | ||
Comment 5•3 years ago
|
||
Thanks! Sorry for being picky. Looks very consistent now.
Assignee | ||
Comment 6•3 years ago
|
||
No problem!
Comment 7•3 years ago
|
||
bugherder |
Description
•